Skip to content

Test: Fix solarish_tap test on big-endian targets#2743

Open
joshuaissac wants to merge 1 commit intonix-rust:masterfrom
joshuaissac:fix-solarish-tap
Open

Test: Fix solarish_tap test on big-endian targets#2743
joshuaissac wants to merge 1 commit intonix-rust:masterfrom
joshuaissac:fix-solarish-tap

Conversation

@joshuaissac
Copy link
Copy Markdown

What does this PR do

This change corrects the solarish_tap test on big-endian Solaris targets.

The two changes are to populate multi-byte numbers in the byte array using the native endianness (previous code assumed little-endianness), and to use a buffer that guarantees the required alignment when taking a pointer to it (previous code guaranteed only 1-byte alignment).

Tested on Solaris 11.4 (SPARC 64-bit).

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@joshuaissac
Copy link
Copy Markdown
Author

Check i686-unknown-linux-musl failing due to unrelated reason:

docker: failed to copy: httpReadSeeker: failed open: failed to do request: Get "https://ghcr.io/v2/cross-rs/i686-unknown-linux-musl/blobs/sha256:8db86b1b7e4e0172fc34ed0a051c46a56ff9d90065ea000c332b2442e012af82": EOF

joshuaissac added a commit to joshuaissac/nix that referenced this pull request Feb 14, 2026
Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test change looks good. But I request that you remove the changelog entry. This change isn't visible to our crate's consumers, so it doesn't need to be mentioned in the changelog.

@joshuaissac
Copy link
Copy Markdown
Author

The test change looks good. But I request that you remove the changelog entry. This change isn't visible to our crate's consumers, so it doesn't need to be mentioned in the changelog.

@asomers Changelog entry removed.

@joshuaissac joshuaissac requested a review from asomers April 8, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants