-
-
Notifications
You must be signed in to change notification settings - Fork 821
fix(bun): polyfill ReadableStream to strip unsupported type direct #4265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harshagarwalnyu
wants to merge
3
commits into
nitrojs:main
Choose a base branch
from
harshagarwalnyu:fix/bun-preset-readable-stream-direct-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
56edebf
fix(bun): polyfill ReadableStream to strip unsupported type "direct"
harshagarwalnyu 62f94cf
fix(bun): preserve ReadableStream prototype in polyfill and add test
harshagarwalnyu d100d4c
fix(bun): use class extends for ReadableStream polyfill to preserve i…
harshagarwalnyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,32 @@ | ||
| import "#nitro/virtual/polyfills"; | ||
|
|
||
| // React 19's server.edge.js uses ReadableStream({ type: "direct", ... }), a | ||
| // Cloudflare Workers extension. Bun follows the web spec strictly and throws | ||
| // ERR_INVALID_ARG_VALUE for unknown `type` values. Strip it before it reaches | ||
| // Bun's constructor so prerendering works without switching to the node preset. | ||
| // Using class extends preserves the prototype chain so instanceof checks work correctly. | ||
| const _OriginalReadableStream = globalThis.ReadableStream; | ||
| class _PatchedReadableStream extends _OriginalReadableStream { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please check if there is already an upstream tracker issue we can link? (or we can make a minimal report for Bun) |
||
| constructor( | ||
| underlyingSource?: UnderlyingDefaultSource | UnderlyingByteSource, | ||
| strategy?: QueuingStrategy, | ||
| ) { | ||
| if ( | ||
| underlyingSource && | ||
| (underlyingSource as Record<string, unknown>).type === "direct" | ||
| ) { | ||
| const { type: _type, ...rest } = | ||
| underlyingSource as Record<string, unknown>; | ||
| super(rest as UnderlyingDefaultSource, strategy); | ||
| } else { | ||
| super(underlyingSource as UnderlyingDefaultSource, strategy); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // @ts-expect-error -- intentional global override for compat | ||
| globalThis.ReadableStream = _PatchedReadableStream; | ||
|
|
||
| import type { ServerRequest } from "srvx"; | ||
| import { serve } from "srvx/bun"; | ||
| import wsAdapter from "crossws/adapters/bun"; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| export default () => { | ||
| const encoder = new TextEncoder(); | ||
| const stream = new ReadableStream({ | ||
| // @ts-expect-error - direct is a Cloudflare extension | ||
| type: "direct", | ||
| start(controller) { | ||
| controller.enqueue(encoder.encode("bun-direct")); | ||
| controller.close(); | ||
| }, | ||
| }); | ||
|
|
||
| return { | ||
| isStream: stream instanceof ReadableStream, | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.