refactor(aws-lambda): add srvx lambda handlers#4052
Conversation
Export fetch from aws-lambda, aws-lambda-streaming presets Add streaming preview shim
|
@taylorfsteele is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds a ChangesAWS Lambda Preset and Runtime Upgrade
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Standalone nitro + Vite build with a single route. Reproduces the preview 404 stub with preset: 'aws-lambda' (srvx loadServerEntry has no branch for the handler-only export); returns 200 when swapped to preset: 'node-server'. Targeted by nitrojs/nitro#4052.
|
Confirming this PR fixes TSS prerender + link crawling on Installed the pkg.pr.new build into a minimal
Also reproduces the underlying bug without any framework: nitro-only/ — only Related: #4051 (this PR's linked issue), TanStack/router#6562 (stale, same root cause pre-#4011). |
|
Hey @pi0 / any other Nitro maintainers. It's been a little bit since I opened this PR, I think I opened it when I was on alpha.2. I should have some time this month to rework this if there's anything that needs to be fixed or changed, I would love to try to get this in for the next beta release. Or if we needed to wait for more things to go into the beta before these preset-specific fixes go in that's fine too. Let me know if there's anything I can do to assist, more than happy to help. |
|
Hi dear @taylorfsteele thanks for patience and help on this PR. We have recently added actual lamda compatibility to srvx via toLambdaHandler, invokeLambdaHandler (docs) which preview command can leverage it this way |
|
@pi0 Fantastic! I've gone ahead and updated this branch to use the srvx handlers, let me know what you think |
|
Re-tested the reworked PR (pkg.pr.new build, commit b2ab1cb) against the same minimal |
🔗 Linked issue
#4051
❓ Type of change
📚 Description
Closes #4051
This PR removes the previous aws-lambda handlers in favor srvx's lambda handlers.
📝 Checklist