docs(repo): fix the readme demo to a poster link#70
Merged
Conversation
GitHub doesn't render a <video> tag pointing at a committed file (only drag-dropped uploads), so the demo showed nothing. Replace it with a poster frame that links to the mp4's GitHub file page (which has a built-in player). Also drop the now-redundant menubar preview image under How it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<video>tag pointing at a committed mp4 didn't render (GitHub only auto-plays drag-dropped uploads). Swapped it for a poster frame linking to the mp4's GitHub file page, which has a built-in player, so the demo now shows reliably. Also removed the redundant menubar preview image under How it works (the demo covers it).