fix(interpose): non-blocking connect#21
Merged
Merged
Conversation
A connect ran a synchronous round-trip on the calling thread while the host blocked up to 9s for the link, freezing the app past the 5s watchdog. Connect now returns at once; its outcome arrives as a CONNECTED or CONNECT_FAILED event, like the real radio.
0xnirapod
approved these changes
Jun 29, 2026
0xnirapod
left a comment
0xnirapod
left a comment
Member
There was a problem hiding this comment.
Non-blocking connect verified; full make test, docs, and fence green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A central connect ran a synchronous loopback round-trip on the calling thread while the host blocked up to 9 seconds waiting for the link. On the main thread that froze the app past the system's 5-second termination watchdog, which SIGKILLed it.
Connect now returns as soon as the request is issued, matching a real CBCentralManager: the host acknowledges immediately and reports the outcome as a new CONNECTED or CONNECT_FAILED event, which the interposer turns into didConnectPeripheral or didFailToConnectPeripheral.
discoverServices, read, and setNotify keep the synchronous-latch pattern, which resolves quickly over an established connection.