fix(helper): fan events out to every connection#13
Merged
Conversation
`RequestRouter` kept a single event sink, so the last connection served stole event delivery from any earlier reader. Hold an id-keyed sink registry instead and fan each event out to every registered connection. The snapshot is taken under the lock; sinks run outside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestRouterheld a single event sink, so the last connection served stole event delivery from any earlier reader connection (and a one-shot command connection cleared it on close). Replace it with an id-keyed sink registry:attachEventSinkreturns an id,detachEventSink(id)removes that one, and the forward path snapshots the sinks under the lock then invokes them outside it, so every active connection receives every event. Command token-gating is unchanged.