Make the popup dialogs work (canvas), with a demo page. Fix exit issue. - #158
Merged
Merged
Conversation
cmeyer
commented
Sep 18, 2026
Contributor
- Fix the select item popup with no items or an invalid current item.
- Size the select item popup and its list to the items rather than to a fixed width.
- Add a popups demo page to the ui demo application.
- Do not register a window without a parent as a dialog of the application.
- Create a child canvas window under the window of the host user interface.
- Pass the host window close along to the canvas window which wraps it.
- Take the keyboard focus of the host when a canvas widget is given focus.
- Keep the width asked for when a canvas line edit sizes to its text.
- Make the edit string popup field fill the popup.
- Do not ask the host to quit from within a window close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.