Skip to content

Annotated array class as successor to DataAndMetadata/Calibration. - #79

Closed
cmeyer wants to merge 16 commits into
nion-software:masterfrom
cmeyer:annotated-array
Closed

cmeyer wants to merge 16 commits into
nion-software:masterfrom
cmeyer:annotated-array

Conversation

@cmeyer

@cmeyer cmeyer commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cmeyer
cmeyer force-pushed the annotated-array branch from 2a1d15b to d3d9a45 Compare July 25, 2026 00:11
@cmeyer
cmeyer force-pushed the annotated-array branch from 1b7149d to bbd6eba Compare July 25, 2026 00:35
@KRLango

KRLango commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

I cannot see anything that defines axes as datum/collection/sequence. Should this be covered in these changes as well or is that going to be defined elsewhere?

@cmeyer

cmeyer commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I cannot see anything that defines axes as datum/collection/sequence. Should this be covered in these changes as well or is that going to be defined elsewhere?

This is the point of this change - no axis group gets special treatment except the last, which is the signal axis group.

See https://github.com/nion-software/nionswift/blob/master/design/data_model.md

@KRLango

KRLango commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

But aren't there situations where we will need to know which axes are which, e.g. trying to do a Join Sequence?

@cmeyer

cmeyer commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

But aren't there situations where we will need to know which axes are which, e.g. trying to do a Join Sequence?

It's just programming: check whether there are two or more axis groups and whether the first (outermost) axis group has a rank of one.

@KRLango

KRLango commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

It's just programming: check whether there are two or more axis groups and whether the first (outermost) axis group has a rank of one.

That would mean we could use it on any rank one axis group that is first - which would be a change in functionality. I cannot see a problem with that, so this is looking good to me.

@cmeyer

cmeyer commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor Author

Detailing the processing operations turned up more properties we need to track in the annotated array — mostly around reciprocal space and hermitian data. Additive, nothing existing breaks. I'll add them to the data design document and this class for review.

@cmeyer
cmeyer marked this pull request as ready for review August 18, 2026 18:05
@cmeyer

cmeyer commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Merged 4990fbe

@cmeyer cmeyer closed this Aug 18, 2026
@cmeyer
cmeyer deleted the annotated-array branch August 18, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants