Fix #75. Improve slice key type typing to be more specific. - #76
Merged
Merged
Conversation
cmeyer
marked this pull request as draft
December 8, 2025 17:23
cmeyer
force-pushed
the
fix-75-cleanup-slice-typing
branch
from
December 8, 2025 17:28
b034cac to
ea73edc
Compare
cmeyer
marked this pull request as ready for review
December 8, 2025 17:31
Collaborator
|
This fixes my issue, thanks! Tested with the following code snippet: from nion.data import xdata_1_0 as xd
import numpy as np
xdata = xd.new_with_data(np.zeros((100, 100, 100)))
xd.data_slice(xdata, (slice(10, 20), slice(20, 40))) |
Brow71189
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75.
If this isn't sufficient, please provide a line of client code that should pass typing but doesn't.