Repository navigation
Create Overview Scan panel from WideFieldAcquisition.py - #66
lizziewylie wants to merge 34 commits into
Conversation
cmeyer
left a comment
There was a problem hiding this comment.
Minor drive-by comments. I'm aware this is draft, btw.
cmeyer
left a comment
There was a problem hiding this comment.
I'm only adding review for coding style, not for functionality or general algorithm logic.
Brow71189
left a comment
There was a problem hiding this comment.
I haven't tried it, just a comment from reading through the code inline below. Apart from that it looks fine.
MattRoyle
left a comment
There was a problem hiding this comment.
Mostly pedantic. Main bits are suggesting that the exporting is done via existing export functionality rather than introducing a new library dependency PIL. The UI line edit handling is done on a per function basis, converting to integers, exiting early if the value is too large. I think using Converters in tandem with property getters and setters would make the code more readable.
MattRoyle
left a comment
There was a problem hiding this comment.
Some issues with the defocus logic and how wide this panel appears.
Brow71189
left a comment
There was a problem hiding this comment.
Some things I notices while reading through the code. Nothing major, but would be nice to fix I think.
|
I'm not following closely along here, but why wouldn't the output of this be a data item? |
|
Independent of requirements and design prerequisites, I don't think this project belongs in experimental. It is an acquisition project and would introduce a package dependency that I don't want to have. It's fine for development here, as long as it is a PR, but ultimately will have to live somewhere else - perhaps nionswift-instrumentation-kit. A low level acquisition procedure (basically the same as your This project will also need comprehensive tests. This project also needs to be split into model and view (UI) packages. |
Fixes nion-software/nion-internal#381