Skip to content

Use the label visibility and background color properties - #93

Closed
MattRoyle wants to merge 2 commits into
nion-software:masterfrom
MattRoyle:label_visibility
Closed

MattRoyle wants to merge 2 commits into
nion-software:masterfrom
MattRoyle:label_visibility

Conversation

@MattRoyle

@MattRoyle MattRoyle commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

Fixes https://github.com/nion-software/nion-internal/issues/304.
Requires nion-software/nionswift#1883.
Sets the text background to white for readability and makes the interval always show the text so it doesn't have to be selected.

@MattRoyle MattRoyle self-assigned this Jun 23, 2026
@MattRoyle
MattRoyle requested review from KRLango and Tiomat85 June 23, 2026 15:47
@cmeyer

cmeyer commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I'm not sure how we want to handle this - but 'role' could also embody the zlp_interval._graphic.color = "black" code. That would make thickness and ZLP position the same color, defined by 'role'. We should run that by end users before a final decision, but it's an option.

As another general comment, we eventually want to do everything by 'role' and 'style' and 'id' instead of explicit colors and other properties, similar to CSS.

@cmeyer

cmeyer commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Merged with 632ba29

@cmeyer cmeyer closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants