chore: repo hygiene — ignore local artifacts, correct AGENTS.md, track the UI/UX audit - #35
Merged
Conversation
Three classes of local-only files were sitting untracked in the working tree and would be swept in by any `git add .`: - .mimocode/ — another agent tool's local cache (~56MB) - docs/*security-audit*.html, docs/*security-review*.html — THIS REPO IS PUBLIC. The three reports enumerate findings with file:line evidence (SSRF surface, cron auth, upload handling, token storage) and embed local absolute paths. Committing them would publish a remediation roadmap to anyone. Keep local, share out-of-band. - public/logos/ + scripts/generate_html.py — logo exploration from the rebrand. Referenced by no code, and anything under public/ is served publicly; logo_data.json alone is ~2MB of base64. Nothing is deleted from disk — these stay locally, they just stop following the repo around.
CLAUDE.md: condensed to the non-obvious. Drops guidance that had gone stale — lib/db.ts initSchema() (removed from the codebase) and the "Prod TODO: set Vercel DATABASE_URL=clockbill_app" (done long ago). AGENTS.md was untracked and had drifted into actively harmful territory: - It opened with `docker compose up -d # PostgreSQL on :5432` and described a `clockbill-db` dev container. There is no local dev DB — .env.local points at the Neon dev branch. CI gets Postgres from GitHub Actions `services:`, not docker-compose.yml; nothing but AGENTS.md referenced that file. - It listed `npm run db:migrate` as the way to apply migrations. That is the one command CLAUDE.md forbids (drizzle journal out of sync) and it has caused a production outage. Replaced with the db:apply flow. Also documents the date/timezone traps found while fixing #32: derive calendar days via lib/dates.ts, never toISOString(); and `date` columns (OID 1082) deserialize as Date objects while typed `string`. Notes that the CI audit gate runs first, so a failure there makes every later step report `skipped` — which reads as "tests passed" but means they never ran.
Matches the existing docs/ convention (docs/product-ux-refresh/, docs/superpowers/plans/). The screenshots need -f because .gitignore blanket-ignores *.png; without them index.html renders with broken images. Verified the dashboard capture is an empty test account — no client names or amounts.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ניקיון של תיקיית העבודה. שלושה קומיטים נפרדים.
1.
.gitignore— מה שלא צריך לעקוב אחריו.mimocode/docs/*security-audit*.htmldocs/*security-review*.htmlfile:line(משטח SSRF ב-web push, אימות cron, טיפול בהעלאות, אחסון טוקנים) וגם מכילים נתיבים מוחלטים מהמחשב שלך. לדחוף אותם = לפרסם מפת דרכים לתוקףpublic/logos/+scripts/generate_html.pypublic/מוגש פומבית —logo_data.jsonלבדו הוא ~2MB של base64שום דבר לא נמחק מהדיסק — הקבצים נשארים אצלך מקומית.
2.
AGENTS.md— היה untracked ועם שתי הוראות שגויותdocker compose up -d # PostgreSQL on :5432ותיאר קונטיינרclockbill-db. אין DB מקומי —.env.localמצביע על ה-dev branch ב-Neon. אימתתי: ה-CI מקבל Postgres מ-services:של GitHub Actions, לא מ-docker-compose.yml, ושום דבר חוץ מ-AGENTS.md לא הפנה לקובץ הזה.npm run db:migrateכדרך להריץ מיגרציות. זו בדיוק הפקודה ש-CLAUDE.md אוסר (ה-journal של drizzle לא מסונכרן), והיא כבר גרמה לתקלה בפרודקשן. הוחלף בתהליךdb:apply.בנוסף תועדו המלכודות מ-#32: לגזור תאריכים דרך
lib/dates.tsולאtoISOString(), ושעמודותdate(OID 1082) חוזרות כאובייקטDateלמרות שהן מטופסותstring.וגם — ששלב ה-audit ב-CI רץ ראשון, ולכן כשהוא נופל כל השאר מסומן
skipped. זה נראה כמו "הבדיקות עברו" אבל המשמעות היא שהן מעולם לא רצו.3.
CLAUDE.md+ דוח UI/UXCLAUDE.mdקוצר לעיקר, והוסרה הדרכה שהתיישנה:initSchema()(כבר לא קיים בקוד) ו-"Prod TODO: set Vercel DATABASE_URL" (בוצע מזמן).docs/ui-ux-audit-2026-07-10/נוסף לפי הקונבנציה הקיימת ב-docs/. הצילומים דורשים-fכי.gitignoreחוסם*.pngגורף — בלעדיהם ה-HTML נשבר. בדקתי את צילום הדשבורד: חשבון בדיקה ריק, בלי שמות לקוחות או סכומים.Test plan
אין שינוי קוד — רק
.md,.gitignoreותיעוד. ה-CI מריץ את הסט המלא (audit → gitleaks → lint → tsc → tests → integration → build).