chore(deps): patch high-severity advisories in postcss, sharp and fast-uri - #33
Merged
Merged
Conversation
…t-uri `npm audit --omit=dev --audit-level=high` (the CI gate) was failing on 5 high advisories, blocking unrelated PRs. Root cause: all of them were transitive under `next`. The `next` entry itself reported range `>=9.3.4-canary.0` with the only "fix" being a downgrade to next@9.3.3 — it was flagged solely via "Depends on vulnerable versions of postcss / sharp", not on its own account. Patching the two transitives clears next as well. - postcss override 8.5.16 -> 8.5.25 (GHSA-r28c-9q8g-f849, path traversal via sourceMappingURL; affects <=8.5.17, so the existing pin was inside the vulnerable range) - sharp: new override ^0.35.3 (GHSA-f88m-g3jw-g9cj, inherited libvips CVE-2026-33327/33328/35590/35591; affects <0.35.0 and next pulls 0.34.5) - fast-uri 3.0.0 -> 3.1.5 via lockfile (GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6, host confusion) `npm audit --omit=dev` now reports 0 vulnerabilities, so the CI gate stays at --audit-level=high rather than being relaxed to critical. Verified: tsc 0, lint clean, 72 test files 0 failed, production build OK (sharp is native and drives image optimization, so the build is the check that matters here).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
למה
ה-gate של
npm audit --omit=dev --audit-level=highב-CI נפל על 5 התראות high וחסם PR-ים שלא קשורים (למשל #32).מה באמת קרה
כל החמש היו טרנזיטיביות תחת
next. הרשומה שלnextעצמו הראתה טווח>=9.3.4-canary.0בלי גבול עליון, והתיקון היחיד ש-npm הציע היה downgrade ל-next@9.3.3 — כלומר ירידה מ-16 ל-9. זה נראה כמו מבוי סתום.אבל
nextסומן רק דרךDepends on vulnerable versions of postcss / sharp, לא בזכות עצמו. ברגע ששתי הטרנזיטיביות מתוקנות —nextמתנקה גם הוא.שינויים
postcss(override)sourceMappingURL. חל על<=8.5.17, כלומר ה-pin הקיים היה בתוך הטווח הפגיעsharp(override חדש)<0.35.0, ו-next מושך 0.34.5fast-uri(lockfile)npm audit --omit=dev→ 0 vulnerabilities.לכן ה-gate ב-CI נשאר
--audit-level=highולא הורד ל-critical, למרות שההערה ב-ci.yml:53-54מתירה את זה. עדיף לא לוותר על הכיסוי כשלא צריך.Test plan
npm audit --omit=dev --audit-level=high→ 0npx tsc --noEmit→ 0npm run lint→ נקיnpm test→ 72 קבצים, 0 נכשלוnpm run build→ exit 0sharpהוא native module שמשמש את אופטימיזציית התמונות של Next, ו-postcssהוא צינור ה-CSS — לכן ה-build הוא הבדיקה המשמעותית כאן, ולא הבדיקות. שניהם עברו.אין שינוי קוד אפליקטיבי, אין מיגרציה.