Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cncn_Zdicno longer works — selecting a Chinese character triggers no popup, with no error in the console.Root cause
zdic.net has redesigned its dictionary pages. The script relied on a single
.jbjscontainer, which no longer exists in the new markup, soquerySelectorreturnsnulland the script silently returns an empty result.Changes
Rewrote
findZdicto scrape the newjbjs-*structure:maxexample)gy-sense__defAlso converted
maxexamplewithNumber()insetOptions, and added a smallrenderCSS().Verification
All new selectors verified against the live zdic.net page for
之(pinyin, zhuyin, 7 senses, 7 example groups, 16 classical senses). The script still satisfies the loader's eval contract.Only
src/dict/cncn_Zdic.jsis changed.