Skip to content

fix(ci): migrate off legacy plugin-based Claude code-review workflow - #8

Merged
twistedmelonman merged 1 commit into
mainfrom
claude/migrate-blocking-review-b2c49b22
Aug 7, 2026
Merged

fix(ci): migrate off legacy plugin-based Claude code-review workflow#8
twistedmelonman merged 1 commit into
mainfrom
claude/migrate-blocking-review-b2c49b22

Conversation

@twistedmelonman

Copy link
Copy Markdown
Contributor

Summary

Replaces the legacy claude-code-review.yml (plugin-based, plugin_marketplaces/plugins: 'code-review@claude-code-plugins', unpinned model, fires on synchronize) with claude-blocking-review.yml, a standard caller stub against the fleet's reusable workflow at smartwatermelon/github-workflows/.github/workflows/claude-blocking-review.yml@v3.

This repo was a straggler from the March 2026 fleet-wide reusable-workflow migration — claude-code-review.yml should have been eliminated then but wasn't caught.

  • Deletes .github/workflows/claude-code-review.yml
  • Adds .github/workflows/claude-blocking-review.yml, explicitly pinning model: claude-haiku-4-5-20251001 for cost control
  • claude.yml (the @claude-mention assistant workflow) is untouched — unrelated

Note for reviewers

This repo already has .github/workflows/claude-required-review.yml, a separate pre-existing caller stub against the same reusable workflow (pinned to @v3.0.0). This PR does not touch or remove it — worth a follow-up decision on whether the two should be consolidated, since they'll now both run on every PR.

Closes smartwatermelon/github-workflows#89

Test plan

  • YAML validated (ruby -ryaml)
  • Local pre-commit/pre-push review (code-reviewer + adversarial-reviewer) passed after arbitration
  • Confirm workflow runs successfully on this PR's own sync events

https://claude.ai/code/session_0143Nf4sXqnTp2Kx3LNbMvBA

Replaces claude-code-review.yml (unpinned model, plugin_marketplaces
pattern predating the March 2026 reusable-workflow migration) with
claude-blocking-review.yml, a caller stub against the fleet's
smartwatermelon/github-workflows reusable at @V3. Model is pinned
explicitly to claude-haiku-4-5-20251001 for cost control.

Closes smartwatermelon/github-workflows#89

Claude-Session: https://claude.ai/code/session_0143Nf4sXqnTp2Kx3LNbMvBA
@twistedmelonman
twistedmelonman merged commit 270094f into main Aug 7, 2026
1 check passed
@twistedmelonman
twistedmelonman deleted the claude/migrate-blocking-review-b2c49b22 branch August 7, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advisory PR-review workflow: trim synchronize trigger, pin model

1 participant