feat(rm): add --rm-url and fix small CLI drift in the docs - #1
Merged
niehen6174 merged 2 commits intoAug 14, 2026
Merged
Conversation
Rockdu
force-pushed
the
fix/pr126-cli-drift
branch
from
August 13, 2026 05:10
bfb37c2 to
0af3072
Compare
Mirrors the miles-core flag of the same name so the two CLIs stay mergeable. No built-in --rm-type consumes it yet; it exists as the standard place for --custom-rm-path functions to read a service endpoint, which the customization guide documents. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXZMxrjDB2V88kSJEGa2cj
- --grpo-std-normalization is not a flag; the registered switch is --disable-grpo-std-normalization (std normalization is on by default). - --diffusion-num-steps defaults to 10, not 'model default'. - Quote the LoRA sync log line as emitted (it ends with 'unmapped=N'). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXZMxrjDB2V88kSJEGa2cj
Rockdu
force-pushed
the
fix/pr126-cli-drift
branch
from
August 13, 2026 05:14
0af3072 to
d3cac3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--rm-urltoadd_reward_model_arguments, mirroring the miles-core flag of the same name (placed before--custom-rm-path, same as there). No built-in--rm-typeconsumes it yet — it is the standard place for--custom-rm-pathfunctions to read a remote service endpoint, which is exactly how the customization guide'sapi_rmexample and the rewards page's remote-RM note already use it.--disable-grpo-std-normalization(on by default;--grpo-std-normalizationis not a flag),--diffusion-num-stepsdefaults to10, and the LoRA sync log line ends with(unmapped=N).Why
Cross-checked every flag in the six pages against
main'sarguments.py(AST) and theFSDPArgsdataclass after the recent args refactor (radixark#132/radixark#138/radixark#141/radixark#142/radixark#148).--rm-urlwas the one flag the pages reference that did not exist — rather than rewriting the (useful) remote-RM examples, this adds the flag the docs assume, keeping the CLI mergeable with miles core. Everything else in the PR already matches post-refactormain.Files
miles/utils/arguments.py— new--rm-urlargument in the reward groupdocs/user-guide/customization.md— std-normalization wordingdocs/advanced/sde-backend.md—--diffusion-num-stepsdefaultdocs/advanced/lora.md— log-line quoteChecklist
pre-commit run --all-files— not run locallypytest -x— not run locallyast.parse);--helpparse not run locally (needs the sglang env)rewards.mdandcustomization.mdin this same PR describe it🤖 Generated with Claude Code
https://claude.ai/code/session_01RXZMxrjDB2V88kSJEGa2cj