Skip to content

feat(rm): add --rm-url and fix small CLI drift in the docs - #1

Merged
niehen6174 merged 2 commits into
niehen6174:docs/user-guidesfrom
Rockdu:fix/pr126-cli-drift
Aug 14, 2026
Merged

feat(rm): add --rm-url and fix small CLI drift in the docs#1
niehen6174 merged 2 commits into
niehen6174:docs/user-guidesfrom
Rockdu:fix/pr126-cli-drift

Conversation

@Rockdu

@Rockdu Rockdu commented Aug 13, 2026

Copy link
Copy Markdown

What

  • Add --rm-url to add_reward_model_arguments, mirroring the miles-core flag of the same name (placed before --custom-rm-path, same as there). No built-in --rm-type consumes it yet — it is the standard place for --custom-rm-path functions to read a remote service endpoint, which is exactly how the customization guide's api_rm example and the rewards page's remote-RM note already use it.
  • Small doc accuracy fixes: the std-normalization switch is --disable-grpo-std-normalization (on by default; --grpo-std-normalization is not a flag), --diffusion-num-steps defaults to 10, and the LoRA sync log line ends with (unmapped=N).

Why

Cross-checked every flag in the six pages against main's arguments.py (AST) and the FSDPArgs dataclass after the recent args refactor (radixark#132/radixark#138/radixark#141/radixark#142/radixark#148). --rm-url was the one flag the pages reference that did not exist — rather than rewriting the (useful) remote-RM examples, this adds the flag the docs assume, keeping the CLI mergeable with miles core. Everything else in the PR already matches post-refactor main.

Files

  • miles/utils/arguments.py — new --rm-url argument in the reward group
  • docs/user-guide/customization.md — std-normalization wording
  • docs/advanced/sde-backend.md--diffusion-num-steps default
  • docs/advanced/lora.md — log-line quote

Checklist

  • pre-commit run --all-filesnot run locally
  • Tests — none added; the new argument has no runtime consumer to test
  • pytest -xnot run locally
  • Launch flags changed: the argument block is syntax-checked (ast.parse); --help parse not run locally (needs the sglang env)
  • New public flag is documented — rewards.md and customization.md in this same PR describe it
  • No example added

🤖 Generated with Claude Code

https://claude.ai/code/session_01RXZMxrjDB2V88kSJEGa2cj

@Rockdu
Rockdu force-pushed the fix/pr126-cli-drift branch from bfb37c2 to 0af3072 Compare August 13, 2026 05:10
Rockdu and others added 2 commits August 12, 2026 22:14
Mirrors the miles-core flag of the same name so the two CLIs stay
mergeable. No built-in --rm-type consumes it yet; it exists as the
standard place for --custom-rm-path functions to read a service
endpoint, which the customization guide documents.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RXZMxrjDB2V88kSJEGa2cj
- --grpo-std-normalization is not a flag; the registered switch is
  --disable-grpo-std-normalization (std normalization is on by default).
- --diffusion-num-steps defaults to 10, not 'model default'.
- Quote the LoRA sync log line as emitted (it ends with 'unmapped=N').

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RXZMxrjDB2V88kSJEGa2cj
@Rockdu
Rockdu force-pushed the fix/pr126-cli-drift branch from 0af3072 to d3cac3f Compare August 13, 2026 05:14
@Rockdu Rockdu changed the title docs: drop the nonexistent --rm-url and fix small CLI drift feat(rm): add --rm-url and fix small CLI drift in the docs Aug 13, 2026
@niehen6174
niehen6174 merged commit 70d11fa into niehen6174:docs/user-guides Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants