Repository navigation
[bindings/odin] Fix Windows library generation - #657
Open
giuinktse7 wants to merge 1 commit into
Open
giuinktse7 wants to merge 1 commit into
giuinktse7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered a bug in the way the Clay Windows
.libfile is built when I upgraded to Odin dev-2026-10 (This version of Odin changed the default linker toradlink).The Windows build command for the Clay Odin bindings uses
clang -c, which produces a COFF object file (.obj), but then writes it directly toclay.lib. The MSVC linker accepts the incorrect extension, but radlink crashes.Fixed by compiling to
clay.oand then explicitly invokingllvm-libto correctly create theclay.libarchive.