Conversation
When calculating the width of a line, the width excludes the trailing letter
spacing value:
```c
measuredWidth = CLAY__MAX(lineWidth, measuredWidth) - config->letterSpacing;
```
But when the final layout is being calculated, the letter spacing is added to
the line width of the text. So when it's time to render, the line is actually
longer than the intial max line, so it gets broken up, even though it should
fit.
https://github.com/pope/clay-letterspacing-poc is a little bit of code to test
a before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the width of a line, the width excludes the trailing letter spacing value:
But when the final layout is being calculated, the letter spacing is added to the line width of the text. So when it's time to render, the line is actually longer than the intial max line, so it gets broken up, even though it should fit.
https://github.com/pope/clay-letterspacing-poc is a little bit of code to test a before and after. Though I recognize there may be other use-cases I'm not hip to.
If this PR isn't the move, I don't mind opening up an issue to track this.