Conversation
Owner
|
Thanks for this, it was literally just an oversight 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
CLAY_TRANSITION_PROPERTY_CORNER_RADIUSwas not implemented by #579. Not sure if this was an intentional decision pending additional considerations or just forgotten, but I couldn't find any comments or commits that explicitly mentioned it.As a side note, I've chosen to use
Clay__FloatEqualwhen evaluating the active properties, which is what theX/Y/WIDTH/HEIGHTproperties use, but color properties are also backed by floating point values and useClay__MemCmp.