Menu button updates for table#986
Merged
Merged
Conversation
jattasNI
approved these changes
Jan 23, 2023
rajsite
reviewed
Jan 24, 2023
atmgrifter00
approved these changes
Jan 24, 2023
msmithNI
approved these changes
Jan 24, 2023
rajsite
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Some changes need to be made to the menu button before it can be used within the table for the action menu. Specifically, those changes are:
beforetoggleeventSee #956 for more details.
👩💻 Implementation
beforetoggleevent to the menu button that is fired before the menu opens or closesbeforetoggleeventmenubecause this won't matchslotelements. Instead, the template assigns all slotted elements to theslottedMenusarray, and the getter formenufinds the menu, which may be nested withinslotelements.🧪 Testing
beforetoggleevent handler works correctly in Blazor & Angularbeforetoggleevent works correctly for the web components✅ Checklist