ni.protobuf.types - Update nitypes dependency to 1.1.0dev3#336
Open
hunter-ni wants to merge 2 commits into
Open
ni.protobuf.types - Update nitypes dependency to 1.1.0dev3#336hunter-ni wants to merge 2 commits into
hunter-ni wants to merge 2 commits into
Conversation
Signed-off-by: Hunter Kennon hunter.kennon@emerson.com
Contributor
hunter-ni
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ni.protobuf.types to require a newer pre-release of nitypes so downstream users can pick up the referenced upstream bug fix.
Changes:
- Bump
nitypesdependency constraint from>=1.1.0dev1to>=1.1.0dev3(prereleases allowed). - Regenerate
poetry.lockto resolve tonitypes 1.1.0.dev3and update the lock metadata hash.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ni.protobuf.types/pyproject.toml | Updates the nitypes dependency minimum version to 1.1.0dev3 (prerelease). |
| packages/ni.protobuf.types/poetry.lock | Locks the resolved nitypes package to 1.1.0.dev3 and updates hashes/content-hash accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nsistency with how other packages are specified Signed-off-by: Hunter Kennon hunter.kennon@emerson.com
hunter-ni
requested review from
bkeryan,
dixonjoel and
jfriedri-ni
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This set of changes updates the
ni.protobuf.typespackage to depend on a more recent (pre-release) version of thenitypespackage. This is being done primarily so that a recent bug fix innitypescan be propagated to clients ofni.protobuf.types.I've also added a
.beforedev3in the package version specification for consistency with how other pre-release packages are specified in the repo.Why should this Pull Request be merged?
This PR keeps
ni.protobuf.typesin sync with the latest bug fix innitypes.What testing has been done?
Existing
ni.protobuf.typestests pass