This repository was archived by the owner on Sep 4, 2020. It is now read-only.
Write batch#56
Open
kkoser wants to merge 2 commits into
Open
Conversation
Added a new WriteBatch class that wraps the native leveldb implementation. It allows for batching multiple requests together and then committing all of those actions at the same time. Also added tests for the new WriteBatch feature.
Owner
|
Hi @kkoser thanks for the PR (&@littledot for the initial review), it looks neat I'll give it a full review & work on it probably next week-end There are couple of aspect we need to check
|
Author
|
Hi @nhachicha is there anything I can do to help get this merged? Thanks!! |
Owner
|
The general idea LGTM, although we need to find a way to reduce code duplication for been very busy with work lately, but hopefully I'll have the chance to review in more details probably this WE. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature implementation for #47. This provides the ability to create and commit WriteBatches to the DB by wrapping the native leveled WriteBatch class.