fix(web-app): show default map icon for forms without select fields - #461
Merged
Merged
Conversation
The Default symbology card was only rendered when a form had select fields and a primary field was chosen, making the default icon unreachable otherwise. It now always renders and displays the actual uploaded icon via getIconUrl instead of a static placeholder.
restjohn
approved these changes
Jul 27, 2026
restjohn
added a commit
that referenced
this pull request
Jul 28, 2026
* fix: set docker image user/group to 999 to match existing images and file system ownership * chore(ci): update all actions workflows to latest checkout and setup-node actions * chore(nga-msi): upgrade typescript * feat: add msi plugin to dev image * chore: remove unused ldif file * ci: set a custom input tag to publish the dev container image * fix: typo in dockerfile * fix: bad package name in dockerfile * fix(ci): consistent image url across steps * fix(ci): missing closing brackets * fix(ci): missing quotes * fix(ci): wrong image url * fix(ci): missing step id * fix(ci): remove extra quotes around image url to fix trivy step * fix(sftp/web): bad import in showcase app * fix(sftp): bump beta version for publish * chore(nga-msi): bump patch version * chore(ci): add oidc token permissions to release workflow per npm docs * chore(image.service): remove beta qualifier from package version * refactor(ci): rename release to release.core * chore(ci): upgrade download-artifact actions to v8 * chore(ci): upgrade release action to v3 * chore(ci): remove mistakenly added oidc permissions block * refactor(ci): rename plugin release workflows hierarchically * fix(web-app): show default map icon for forms without select fields (#461) The Default symbology card was only rendered when a form had select fields and a primary field was chosen, making the default icon unreachable otherwise. It now always renders and displays the actual uploaded icon via getIconUrl instead of a static placeholder. * fix: remove duplicate docker section from readme * refactor(ci): add container image workflow for prod and rename dev image workflow to match hierarchically * fix: typos in readme * chore(container): use multistage build with distroless/rootless image for prod container image; add image plugin to container image * feat(ci): use oidc trusted publishing for plugin release workflows * fix(ci): remove reference to absent plugins in core release workflow * feat(ci): use publish dry run for draft release in core release workflow --------- Co-authored-by: Billy Newman <3382274+newmanw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Default symbology card was only rendered when a form had select fields and a primary field was chosen, making the default icon unreachable otherwise. It now always renders and displays the actual uploaded icon via getIconUrl instead of a static placeholder.