Fix Windows/MinGW build: missing err.h, uninitialized pointer in stdlib.c

src/nfc-utils.c

@@ -37,7 +37,6 @@
  * @brief Provide some examples shared functions like print, parity calculation, options parsing.
  */
 #include <nfc/nfc.h>
-#include <err.h>
 
 #include "nfc-utils.h"
 

src/nfc-utils.h

@@ -43,7 +43,20 @@
 
 #  include <stdlib.h>
 #  include <string.h>
-#  include <err.h>
+#  ifdef _WIN32
+#    include <stdio.h>
+#    include <stdarg.h>
+static inline void warnx(const char *fmt, ...)
+{
+  va_list ap;
+  va_start(ap, fmt);
+  vfprintf(stderr, fmt, ap);
+  va_end(ap);
+  fprintf(stderr, "\n");
+}
+#  else
+#    include <err.h>
+#  endif
 #  include <nfc/nfc-types.h>
 
 /**

src/stdlib.c

@@ -40,19 +40,19 @@ int setenv(const char *name, const char *value, int overwrite)
 {
   char *env = getenv(name);
   if ((env && overwrite) || (!env)) {
-    char *str[32];
-    strcpy(*str, name);
-    strcat(*str, "=");
-    strcat(*str, value);
-    return _putenv(*str);
+    char str[32];
+    strcpy(str, name);
+    strcat(str, "=");
+    strcat(str, value);
+    return _putenv(str);
   }
   return -1;
 }
 
 void unsetenv(const char *name)
 {
-  char *str[32];
-  strcpy(*str, name);
-  strcat(*str, "=");
-  _putenv(*str);
+  char str[32];
+  strcpy(str, name);
+  strcat(str, "=");
+  _putenv(str);
 }

src/windows.h

@@ -35,7 +35,6 @@
 
 #  include <windows.h>
 #  include <winerror.h>
-#  include <err.h>
 #  if defined (__MINGW32__)
 /*
  * Cheating here on the snprintf to incorporate the format argument