New module baysor#11790
Open
khersameesh24 wants to merge 17 commits into
Open
Conversation
…into new-module-baysor
SPPearce
reviewed
Jun 2, 2026
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
I think most of my comments apply to all three tools.
Generally please make only one PR at a time.
Contributor
Author
|
@SPPearce all comments have been addressed |
SPPearce
reviewed
Jun 3, 2026
Comment on lines
+20
to
+21
| file("https://raw.githubusercontent.com/khersameesh24/test-datasets/baysor/transcripts.parquet", checkIfExists: true), | ||
| file("https://raw.githubusercontent.com/khersameesh24/test-datasets/baysor/config/xenium.toml", checkIfExists: true) |
Contributor
There was a problem hiding this comment.
Can you please add the test data to the nf-core/testdatasets repository, in the modules branch. Don't put it in delete_me.
| preview \\ | ||
| ${transcripts} \\ | ||
| --config ${config} \\ | ||
| --output ${prefix} \\ |
Contributor
There was a problem hiding this comment.
Can this just output into the current directory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new module baysor
Closes #11785 #7270
PR checklist
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda