Add new module: octopusv/stat#11719
Conversation
manascripts
force-pushed
the
octopusv-stat
branch
from
5bf76ea to
10de022
Compare
|
@mashehu, Can I please get a review again? |
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot( | ||
| path(process.out.txt.get(0).get(1)), |
There was a problem hiding this comment.
is the txt output changing between runs?
Also at least check the file name for the html output
There was a problem hiding this comment.
The text output should not change. What test should should I add for this file?
Also at least check the file name for the html output
I will add that, thanks!
There was a problem hiding this comment.
just snapshot process.out.txt then
There was a problem hiding this comment.
the standard is to call this file nextflow.config
|
@mashehu, everything is in order, can I please get an approval? thanks! |
| @@ -0,0 +1,5 @@ | |||
| process { | |||
| withName: 'OCTOPUSV_STAT' { | |||
| ext.args = "--report" | |||
There was a problem hiding this comment.
We want the ext.args to be present in the main.nf.test file. That makes everything more readable in one go. See the module specifications for more info.
There was a problem hiding this comment.
I have updated it, thanks!
3 participants
PR checklist
Add a new module: octopusv/stat
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda