Skip to content

Move to 2.2.0#236

Merged
nservant merged 59 commits into
nf-core:devfrom
Thibault-Poinsignon:dev
May 6, 2026
Merged

Move to 2.2.0#236
nservant merged 59 commits into
nf-core:devfrom
Thibault-Poinsignon:dev

Conversation

@Thibault-Poinsignon

Copy link
Copy Markdown

Version 2.2.0

Added

  • Subworkflows meta.yml
  • Module FAIDX for chromosomes sizes calculation
  • TRIMGALORE module for 5' clipping (see Improve pipeline for Arima Hi-C protocol #225)
  • CALDER2 compartments calling (see '--compartments_caller' option)
  • Local FILTER_CHROMSIZE module (in order to apply CALDER2 without error)
  • Optional '--min_size' parameter for chromosome selection
  • Default MIN_FRAG_SIZE, MAX_FRAG_SIZE, MIN_INSERT_SIZE and MAX_INSERT_SIZE values for Arima and ArimV2 protocols

Removed

  • Module GETCHROMSIZES (replaced by FAIDX)
  • Version channels from subworkflows (tools versions gathering still a WIP)

Fixed

Updated

  • All nf-core modules (including topics channel)
  • Modules path
  • "channel" syntax with lowercase c
  • Components names in subworkflows meta.yml
  • COOLER_CLOAD inputs and outputs
  • BWA_MEM inputs
  • SAMTOOL_SORT inputs
  • UTILS_NFSCHEMA_PLUGIN inputs and outputs
  • Markdown settings
  • Template files
  • nf-core version to 3.5.0

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,singularity --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse

Copy link
Copy Markdown
Member

This version looks good to me ! thank you @Thibault-Poinsignon @maxulysse, any advice for the tests which are still failing ? Could we move forward like this. We would like to release a new stable version asap.

I'd recommend to try and merge #233 and/or #234 to have a minimal test using nf-test

Comment thread workflows/hic.nf Outdated
@Thibault-Poinsignon

Copy link
Copy Markdown
Author

All the checks are now successful with the two template updates. I'm running some full tests again to verify that everything is still working properly.

@ewels

ewels commented Mar 18, 2026

Copy link
Copy Markdown
Member

@nf-core-bot fix linting

@Thibault-Poinsignon

Copy link
Copy Markdown
Author

It should be good to go

@Thibault-Poinsignon Thibault-Poinsignon requested review from maxulysse and removed request for maxulysse April 7, 2026 13:45

@nservant nservant left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to me

@nservant nservant merged commit e0084ae into nf-core:dev May 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants