Skip to content

strict syntax compatibility#130

Open
nvnieuwk wants to merge 1 commit intodevfrom
comp/strict-syntax
Open

strict syntax compatibility#130
nvnieuwk wants to merge 1 commit intodevfrom
comp/strict-syntax

Conversation

@nvnieuwk
Copy link
Member

@nvnieuwk nvnieuwk commented Mar 5, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • Parameters Documentation is updated with nf-core schema docs --format markdown --output docs/parameters.md --force
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk nvnieuwk requested a review from matthdsm March 5, 2026 14:58
def base = "${meta.id}/${meta.id}${meta.variant_type ? '.' + meta.variant_type : ''}"
vcf >> "${base}.vcf.gz"
tbi >> "${base}.vcf.gz.tbi"
vcf >> "${meta.id}/${meta.id}${meta.variant_type ? '.' + meta.variant_type : ''}" + ".vcf.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not needed as all logic happens in a string interpolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants