Skip to content

Use shared merge_inputs module - #112

Draft
victorlin wants to merge 3 commits into
mainfrom
victorlin/shared-merge-inputs
Draft

Use shared merge_inputs module#112
victorlin wants to merge 3 commits into
mainfrom
victorlin/shared-merge-inputs

Conversation

@victorlin

@victorlin victorlin commented Jul 9, 2026

Copy link
Copy Markdown
Member

Note

shared/vendored pulled from unmerged nextstrain/shared#79
Only runs with unreleased changes from nextstrain/augur#2026

Description of proposed changes

Reduces the amount of workflow-specific code.

Related issue(s)

Follow-up to nextstrain/pathogen-repo-guide#108 (comment)

Checklist

  • Tested locally
  • Checks pass
  • Update changelog

Comment thread phylogenetic/Snakefile Outdated
Comment on lines 17 to 18
include: "../shared/vendored/snakemake/init.smk"
include: "../shared/vendored/snakemake/config.smk"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced 018d9ad with 7e10dc5.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for prototyping the modules @victorlin! I'm still a little wary of the abstraction of rules in this file, but at least the underlying rules are in the same repo. Will think on this a little more...

subrepo:
  subdir:   "shared/vendored"
  merged:   "c9497c4"
upstream:
  origin:   "https://github.com/nextstrain/shared"
  branch:   "victorlin/merge-inputs"
  commit:   "c9497c4"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "4f60dd7"
Previously, AUGUR_SEARCH_PATHS was automatically set upon inclusion of
config.smk. An explicit call to a function is now needed.
Reduces the amount of workflow-specific code.
@victorlin
victorlin force-pushed the victorlin/shared-merge-inputs branch from feece50 to c69bffc Compare July 14, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants