Move s3_dst config to top level config - #215
Closed
j23414 wants to merge 1 commit into
Closed
Conversation
Nested configs for s3 URLs are challenging to override by the Snakemake `--config` option, as discussed in the following comment: nextstrain/dengue#13 (comment) This moves the url to the top level, and propagate those changes to the relevant Snakefiles.
j23414
changed the title
Contributor
Author
|
Since we can use: nextstrain/dengue#13 (comment) This PR is no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Nested configs for s3 URLs are challenging to override by the Snakemake
--configoption, as discussed in the following comment:nextstrain/dengue#13 (comment)
This moves the url to the top level as a
s3_dstconfig value, and propagate those changes to the relevant Snakefiles.It's important to note that I haven't conducted thorough testing, and there may be nuances in the implementation meant by the comment. Suggestions or clarification welcome.
Additionally, I was unsure regarding whether the
s3_dstconfig should be a required value or an optional default (Snakemake styleguide: config values).Related issue(s)
Checklist