Add phylogenetic directory - #18
Conversation
Move phylogenetic workflow from top-level to phylogenetic directory to follow the [Pathogen Repo Guide](https://github.com/nextstrain/pathogen-repo-guide/tree/main)
Part of work to update this repo to match the pathogen-repo-guide.
Part of work to update this repo to match the pathogen-repo-guide.
Part of work to update this repo to match the pathogen-repo-guide.
Part of work to update this repo to match the pathogen-repo-guide.
Following the pathogen-repo-guide and nextstrain/zika@efe11e3
Update top-level and phylogenetic `README.md` files to match new workflow structure that includes ingest and phylogenetic directories, following the pathogen-repo-guide
Add empty top-level `nextstrain-pathogen.yaml` to allow `nextstrain build` to work from any directory regardless of runtime, as described [here](nextstrain/pathogen-repo-guide@e318589)
jameshadfield
left a comment
jameshadfield
left a comment
There was a problem hiding this comment.
Thanks for the structured commits & messages - very easy to ready through. I can build the DAG locally so I suspect this is all working as it should, but I'll defer to @joverlee521 who is the best placed to review the changes here.
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for reworking it to make clear step-by-step commits!
The CI workflow was able to complete successfully 🎉
In case you haven't explored it yet, you can download the outputs from the CI workflow in the "Artifacts" section. The downloaded outputs should include the artifact_paths that you defined in the ci.yaml. This includes the example Auspice JSON output that you can drag on to auspice.us for a quick review.
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Looks good to me 👍
For future reference, the docstrings in the snakemake rules were reduced in 1b5c544 after discussion with @kimandrews, @j23414, and myself.
As @jameshadfield commented in a separate PR, these docstrings are prone to falling out of sync. We will be stringent about these docstrings in the zika repo because the zika repo will be used in our tutorials, but other pathogen repos can have generalized docstrings to reduce maintenance.
4 participants
Description of proposed changes
Add phylogenetic directory to follow the pathogen-repo-guide, and update the CI workflow to match the new file structure.
Many changes follow those made in the dengue repo and the zika repo
Checklist