Prepare phylogenetic workflow for Nextclade workflow - #57
Merged
Conversation
genehack
approved these changes
May 24, 2024
| --group-by {params.group_by} \ | ||
| --sequences-per-group {params.sequences_per_group} \ | ||
| --min-length {params.min_length} \ | ||
| --include {input.include} \ |
Contributor
There was a problem hiding this comment.
- is it worth putting this closer to the
--excludeoption to make it clear both are in play? - is it worth a comment explaining how
--excludeand--includeinteract, or is that assumed to be table-stakes knowledge for anybody that might want to modify this?
Contributor
Author
There was a problem hiding this comment.
- I meant to put
--includenext to--exclude. I got faked out by--exclude-where, thanks for flagging! - The comments explaining how
--excludeand--includeinteract is mostly pointing to augur filter docs, aka, not commented here. However, when I get into lineage defining strains, the "include.txt" may need to be split out into DENV1-DENV4 and I haven't figured out the design for that yet.
Potential design 1: Keep separate include_{serotype}.txt files
Potential design 2: Create a snakemake rule that takes a lineage.tsv and creates include_{serotype}.txt and append_clade_membership_{serotype}.tsv... I haven't written this up yet.
Contributor
Author
Adds a configurable includes_{serotype}.txt to force-include key strains
(e.g. vaccine-related, lineage-defining) for each serotype tree.
j23414
force-pushed
the
56-prep-phylo-branch-for-nextclade
branch
from
May 24, 2024 20:26
3ed18d2 to
5af15a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Following the plan laid out in #21 (comment)
This PR is making some minor updates to the
phylogeneticworkflow to prepare for the Nextclade workflow.Related issue(s)
Checklist