Skip to content

Dynamically generate the auspice config files - #45

Merged
j23414 merged 3 commits into
mainfrom
dynamic-auspice-config
Apr 30, 2024
Merged

Dynamically generate the auspice config files#45
j23414 merged 3 commits into
mainfrom
dynamic-auspice-config

Conversation

@j23414

@j23414 j23414 commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Description of proposed changes

As requested here: #18 (comment) , implemented dynamic generation of the Auspice config files.

Additionally, included "Nextclade genotype" coloring to the the tree, which will help with dataset validation and debugging.

Related issue(s)

#18

Checklist

  • Checks pass

@j23414
j23414 requested a review from a team April 25, 2024 23:49
j23414 added 2 commits April 26, 2024 11:17
Instead of maintaining 5 auspice config files, we can generate them.

This becomes more important as we support gene builds (e.g. supporting
"genome" and "E" gene builds will result in 10 auspice config files).
Coloring the tree based on the Nextclade genotype assignments as well as
the "augur clades" call allows for debugging and validation of the Nextclade
dataset.
@j23414
j23414 force-pushed the dynamic-auspice-config branch from 46b543c to d4a56aa Compare April 26, 2024 18:17
@j23414

j23414 commented Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

Tested the phylogenetic workflow (using dynamically generated auspice files) from a GitHub Action (Phylogenetic): https://github.com/nextstrain/dengue/actions/runs/8852723611

The results are on staging and can be viewed below:
all | denv1 | denv2 | denv3 | denv4

The "Nextclade genotype" annotation was being displayed out of order in the
color scheme. This commit adds a color ordering file that can be used to specify
the order of colors for nextclade_genotype, country, region, and recency.

This was copied and modified from the "colors" rule in RSV's workflow

* https://github.com/nextstrain/rsv/blob/a1788ce2c9c4375fb5a06d1426c64c45cf90225f/workflow/snakemake_rules/export.smk#L13-L27
@j23414

j23414 commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

After fixing the color order (86d9641) and rerunning phylogenetic, the fixed results can be viewed below:

all | denv1 | denv2 | denv3 | denv4

@j23414

j23414 commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Going to merge this PR, to unblock rebasing and working on #18

Post-merge review still welcome

@j23414
j23414 merged commit e79a8cd into main Apr 30, 2024
@j23414
j23414 deleted the dynamic-auspice-config branch April 30, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant