Conversation
24 of 28 tasks
corneliusroemer
marked this pull request as ready for review
July 12, 2024 15:04
3 of 4 tasks
victorlin
reviewed
Jul 12, 2024
victorlin
previously approved these changes
Jul 16, 2024
victorlin
left a comment
victorlin
left a comment
Member
There was a problem hiding this comment.
Looks good pending cleanup of commits or squash+merge on GitHub
tsibley
previously requested changes
Jul 17, 2024
corneliusroemer
commented
Jul 17, 2024
Member
Author
|
Will take a few minutes for gzip arm64 to become available, rerun later then it should work Update: it works |
Member
Author
I will squash :) |
corneliusroemer
requested review from
genehack,
huddlej,
jameshadfield and
joverlee521
July 22, 2024 19:11
corneliusroemer
changed the title
Member
|
I'm picking this up since I'd like to run MAFFT natively on my M1 Mac and this would be a proper way to allow that in managed runtimes. |
The osx-arm64 build of unzip provided by conda cannot extract the info
file from the conda package. The error is apparent when running with
unzip directly:
skipping: info-nextstrain-base-20250203T230808Z-h60d57d3_0.tar.zst need PK compat. v4.5 (can do v2.1)
p7zip does not have this issue.
victorlin
removed request for
genehack,
huddlej,
jameshadfield,
joverlee521 and
tsibley
February 5, 2025 00:09
Member
|
I've gathered and dropped what seems to be unnecessary changes as 3fc1f03. Changes are minimal now and this is ready for re-review. |
victorlin
changed the title
tsibley
approved these changes
Feb 5, 2025
tsibley
left a comment
tsibley
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I pushed two commits as an alternative to the temporary commit (see comment); take it or leave it!
It seems unnecessary to tank the build just because we fail to generate a package diff.
Avoids letting the issue surface as more distant and perplexing errors in jq and wget.
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
May 15, 2025
When supported, new setups will get osx-arm64 instead of osx-64 and existing setups will be upgraded from osx-64 → osx-arm64. If the version of nextstrain-base that's being installed/upgraded (or more likely, downgraded to) to does not have an osx-arm64 build, then an osx-64 build will be used instead (provided Rosetta 2 is enabled). Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com> Related-to: <#379> Related-to: <nextstrain/conda-base#80>
Merged
1 of 2 tasks
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
May 15, 2025
When supported, new setups will get osx-arm64 instead of osx-64 and existing setups will be upgraded from osx-64 → osx-arm64. If the version of nextstrain-base that's being installed/upgraded (or more likely, downgraded to) to does not have an osx-arm64 build, then an osx-64 build will be used instead (provided Rosetta 2 is enabled). Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com> Related-to: <#379> Related-to: <nextstrain/conda-base#80>
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
May 19, 2025
When supported, new setups will get osx-arm64 instead of osx-64 and existing setups will be upgraded from osx-64 → osx-arm64. If the version of nextstrain-base that's being installed/upgraded (or more likely, downgraded to) to does not have an osx-arm64 build, then an osx-64 build will be used instead (provided Rosetta 2 is enabled). Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com> Related-to: <#379> Related-to: <nextstrain/conda-base#80>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Build conda-base for osx-arm64 as well.
Related issue(s)
Resolves #77
Checklist