[view] Update for Auspice v3 - #541
Draft
jameshadfield wants to merge 1 commit into
Draft
jameshadfield wants to merge 1 commit into
jameshadfield wants to merge 1 commit into
Conversation
for Auspice v3 which no longer uses `--datasetDir` and `--narrativeDir`. There's the potential for a small change in behaviour as Auspice v3 now looks for datasets and narratives in provided directories rather than separating out dataset-dir & narrative-dir. We use the `first_match_wins` function here to mimic the behaviour if there are duplicate paths.
7 tasks
joverlee521
reviewed
Sep 4, 2026
| # | ||
| # Note that the --datasetDir and --narrativeDir here might be overriden in | ||
| # run() below. | ||
| # NOTE: Auspice v3 uses positional args for datasets/narratives |
Contributor
There was a problem hiding this comment.
Once all runtimes are using Auspice v3 (how can we check this?)
Haven't looked at the changes here in detail yet, but wanted to note this can be done by updating the docker compatible_auspice tag and probably add a new entry to conda ENV_FEATURE. There's nothing in place for versioning in the ambient runtime, but maybe we could add something to test_setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes aren't needed for Auspice v3, as the
auspice viewCLI is backwards compatible and thus will continue to work with the now-deprecated--datasetDir/--narrativeDirarguments.Once all runtimes are using Auspice v3 (how can we check this?) we can merge this PR & release a new CLI version.