subsample: Add helper function for setting --nthreads - #1963
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 74.45% 74.41% -0.04%
==========================================
Files 82 82
Lines 9102 9108 +6
Branches 1855 1856 +1
==========================================
+ Hits 6777 6778 +1
- Misses 2020 2025 +5
Partials 305 305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| def get_parallelism( | ||
| config_file: str, | ||
| config_section: Optional[List[str]] = None, | ||
| limit: int = None | ||
| ) -> int: | ||
| """Compute the degree of parallelism (i.e., optimal value for ``--nthreads``). |
There was a problem hiding this comment.
@jameshadfield do you think this would still be feasible with the augur proximity integration in #1962?
There was a problem hiding this comment.
Can we chat about this tomorrow?
I haven't yet implemented the --nthreads stuff yet, so proximity calculations just run with 1 thread. That's not good - the function is designed to parallalize really well, and without parallalization is unnecessarily slow.
This will be useful in Snakemake workflows to prevent over/under-allocating threads.
ad43e09 to
4af0d31
Compare
|
Closing per nextstrain/docs.nextstrain.org#267 (comment) |
This will be useful in Snakemake workflows to prevent over/under-allocating threads.
Downstream PRs
Checklist
Automated checks passchanges aren't covered by checks