-
Notifications
You must be signed in to change notification settings - Fork 8
feat(admin): add a plugin directory to browse and search published plugins #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f4ca6bd
feat(admin): add a plugin directory to browse and search published pl…
mobeenabdullah 5900991
fix(admin): stop the plugin directory listing featured entries twice
mobeenabdullah 6a6887c
refactor(admin): drop the install-command helper until a page calls it
mobeenabdullah abd925c
feat(admin): give an uninstalled catalogue plugin its own page
mobeenabdullah fcce38e
fix(admin): complete the plugin setup recipe and gate absence on load…
mobeenabdullah d46db16
fix(admin): pin plugin installs to the running admin release
mobeenabdullah 84f69e7
fix(admin): make the setup lines appendable and move the directory of…
mobeenabdullah f7bcbb8
test(admin): cover the branding readiness states
mobeenabdullah a4a9c2a
test(admin): cover branding readiness and state the refetch gap
mobeenabdullah 38f7d8a
fix(admin): give the plugin detail page a loading boundary and report…
mobeenabdullah 477b2ef
fix(admin): classify the plugin directory into the Plugins sidebar se…
mobeenabdullah ef4ee0c
test(admin): size the search debounce wait to the delay it waits on
mobeenabdullah 0c9b264
docs(admin): note that source-mode consumers get an unpinned install …
mobeenabdullah 77d0a32
fix(admin): include the admin-module import and announce copy success
mobeenabdullah 326d7ef
test(admin): restore the original clipboard descriptor between tests
mobeenabdullah 6683d7d
fix(admin): include the editor stylesheet step and raise the card hov…
mobeenabdullah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| "nextly": patch | ||
| "create-nextly-app": patch | ||
| "@nextlyhq/admin": patch | ||
| "@nextlyhq/admin-css": patch | ||
| "@nextlyhq/blocks-engine": patch | ||
| "@nextlyhq/blocks-react": patch | ||
| "@nextlyhq/ui": patch | ||
| "@nextlyhq/adapter-drizzle": patch | ||
| "@nextlyhq/adapter-postgres": patch | ||
| "@nextlyhq/adapter-mysql": patch | ||
| "@nextlyhq/adapter-sqlite": patch | ||
| "@nextlyhq/storage-s3": patch | ||
| "@nextlyhq/storage-uploadthing": patch | ||
| "@nextlyhq/storage-vercel-blob": patch | ||
| "@nextlyhq/plugin-form-builder": patch | ||
| "@nextlyhq/plugin-page-builder": patch | ||
| "@nextlyhq/plugin-seo": patch | ||
| "@nextlyhq/plugin-sdk": patch | ||
| "@nextlyhq/eslint-config": patch | ||
| "@nextlyhq/prettier-config": patch | ||
| "@nextlyhq/telemetry": patch | ||
| "@nextlyhq/tsconfig": patch | ||
| "@nextlyhq/builder": patch | ||
| "@nextlyhq/module-specifiers": patch | ||
| --- | ||
|
|
||
| The admin now has a plugin directory, at Plugins then Browse plugins. | ||
|
|
||
| It lists the plugins Nextly publishes with a description, category and author, marks the ones already installed, and searches by name, description and tags. A curated row sits above the grid while there is more in the grid than in the row. | ||
|
|
||
| It is discovery only. Installing a plugin means adding a dependency and a line to `nextly.config.ts`, so the directory never writes to your source or changes plugin state. Where a listed plugin is already installed, its own icon and description are shown rather than the directory's copy of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * The set of icon names the barrel can render. | ||
| * | ||
| * Its own module rather than a line in the barrel, because the type has to | ||
| * refer to the barrel's own exports and a module cannot describe itself | ||
| * without the inline `import()` form that this package's lint rules forbid. | ||
| * | ||
| * @module components/icons/names | ||
| */ | ||
| import type * as Icons from "./index"; | ||
|
|
||
| /** | ||
| * Every icon name this admin can render, derived from the exports rather than | ||
| * listed beside them, so a name and the export it refers to cannot disagree. | ||
| * | ||
| * Curated data that picks an icon — the plugin catalogue — types its icon | ||
| * field as this, and a name the barrel does not carry stops compiling instead | ||
| * of resolving to nothing and silently rendering the caller's generic | ||
| * fallback. | ||
| * | ||
| * Not for icon names that arrive at runtime: a third-party plugin declares | ||
| * `appearance.icon` as a free string this admin cannot constrain, so that path | ||
| * keeps its fallback. | ||
| */ | ||
| export type AdminIconName = keyof typeof Icons; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.