Skip to content

fix(docs): a locale sample stops posing as a continuation, and the sample baseline catches up - #1810

Merged
mobeenabdullah merged 1 commit into
mainfrom
fix/doc-sample-baseline-records-what-compiles
Sep 11, 2026
Merged

mobeenabdullah merged 1 commit into
mainfrom
fix/doc-sample-baseline-records-what-compiles

Conversation

@mobeenabdullah

Copy link
Copy Markdown
Collaborator

What

Repairs main's Lint / Typecheck / Test / Build (and so the blocking CI gate), red at the Doc samples compile step since the first run after my #1769.

Ledger: task:doc-sample-baseline-catches-up, fixing finding:doc-samples-gate-red-since-1769; research research:doc-sample-continuation-match.

What was true on main

  • The job was cancelled or skipped on every main push from feat(nextly): a plugin names the locale it reads or writes in #1769 (4de79a213) until 0121364ce, its first completed run: check:doc-samples refused because more samples were checked than the baseline records — then only docs/plugins/services.mdx, samples 4 → 5, compiled 0 → 1. By 746a7141c, feat(nextly): a text widget declares its prose and the dashboard draws it #1782's new docs/widgets/index.mdx joined it.
  • The rewrite the gate asks for (--write-baseline) refused too: it would have recorded three new diagnostics on services.mdx — ctx, slug, someId in the Querying fence.
  • Why those appeared: the checker compiles a fence that mentions a name an earlier fence declared as that fence's continuation. feat(nextly): a plugin names the locale it reads or writes in #1769's locale sample declared const page; the Querying fence contains pagination: { limit: 20, page: 1 }; the key matched, the Querying fence compiled with the locale sample's names, and its placeholders — never compiled before — became findings.

How

  • The locale sample's variable is frenchPage. The Querying fence no longer matches, services.mdx compiles 0 fences again and records no diagnostics. The fix is to the sample, as the gate's own message asks, not an --allow-new-findings recording of an artefact.
  • The baseline is then rewritten with no override flags and records only coverage gained: pages 50 → 51, samples 343 → 345, services.mdx 4 → 5, docs/widgets/index.mdx added.

Verification

  • Before (on 746a7141c, the control): pnpm check:doc-samples exit 1 with exactly CI's message. After: exit 0; again after the commit hook ran.
  • pnpm test:scripts 1344/1344 (the checker's own tests), check:docs-claims 0, check:docs-compile 0 (66 pages).
  • For the checker's owner, noted in the research node rather than changed here: a use that is an object key still counts as mentioning an earlier const of the same spelling, so this can happen again.

No changeset: docs and a CI baseline only. Integration (postgres)/(mysql) stay red on this PR until #1807 lands — that is main's other red, and it does not gate here.

…mple baseline catches up

main's Lint / Typecheck / Test / Build has failed at 'Doc samples compile'
since the first run after #1769: the gate refuses more coverage than its
baseline records until told. The rewrite it asks for refused too, and rightly:
it would have recorded three new diagnostics on docs/plugins/services.mdx.

Those came from a name. #1769's locale sample declared 'const page', and the
checker reads a later fence that mentions an earlier fence's name as its
continuation - so the Querying fence's 'pagination: { limit: 20, page: 1 }'
made it compile with that sample's names, and its placeholders (ctx, slug,
someId), never compiled before, became findings. Renamed to frenchPage, the
Querying fence stops matching and the page records no diagnostics.

The baseline then records only the coverage gained: services.mdx 4 -> 5
samples, and docs/widgets/index.mdx, new with #1782.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bdda2bd5-abf8-4db8-88df-4e005ce9ae99

📥 Commits

Reviewing files that changed from the base of the PR and between c1fdd9b and 691e389.

📒 Files selected for processing (2)
  • docs/plugins/services.mdx
  • scripts/doc-samples-baseline.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-11T18:37:19.279617Z 691e389 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mobeenabdullah

Copy link
Copy Markdown
Collaborator Author

@codex review

@github-actions

Copy link
Copy Markdown
Contributor

Whole-Repository Code Hygiene Summary

Full dead-code, duplication, and complexity report for the PR branch as it stands now. Playground is excluded. Quality gate enforcement on introduced issues is performed by the Changed files job.

🌿 Fallow

Warning

Review needed

⚠️ 73 code issues · ⚠️ 689 clone groups · ⚠️ 1044 health findings

See inline review comments for per-finding details.

Code issues (73)
Category Count
Unused files 2
Unused exports 5
Unused dependencies 19
Unused devDependencies 6
Unresolved imports 2
Unlisted dependencies 1
Circular dependencies 38
Duplication (689 groups · 28845 lines · 4.1%)
Locations Lines Tokens
schemas/_dialect-bundles/mysql.relations.ts:40-134
schemas/_dialect-bundles/postgres.relations.ts:40-134
schemas/_dialect-bundles/sqlite.relations.ts:40-134
95 593
cli/commands/db-sync-demote.ts:70-75
cli/commands/db-sync-promote.ts:38-43
cli/commands/dev-build.ts:100-105
cli/commands/dev-build.ts:179-184
cli/commands/dev-build.ts:299-304
cli/commands/dev-build.ts:411-416
cli/commands/dev-build.ts:552-557
cli/commands/dev-server.ts:575-580
cli/commands/dev-server.ts:840-845
cli/commands/dev-server.ts:1143-1148
cli/commands/migrate-field-groups.ts:110-115
6 70
entries/EntryList/EntryTableSkeleton.tsx:74-98
collection/components/CollectionTableSkeleton.tsx:94-118
field-group/components/FieldGroupTableSkeleton.tsx:90-114
plugins/components/PluginsTableSkeleton.tsx:86-110
singles/components/SinglesTableSkeleton.tsx:77-101
src/components/table-skeleton.tsx:100-124
25 89
collections/config/validate-config.ts:380-433
field-groups/config/validate-field-group.ts:185-238
singles/config/validate-single.ts:190-243
54 152
dispatcher/handlers/collection-dispatcher.ts:925-967
field-groups/services/field-group-table-provisioning.ts:186-236
singles/services/reconcile-single-companion.ts:110-160
51 149

… and 684 more groups.

Across 422 files.

Complexity (1044 functions above threshold)
File Function Severity Cyclomatic Cognitive CRAP Lines
singles/services/single-mutation-service.ts:981 <arrow> critical 251 ! 324 ! 13859.2 ! 1625
collections/services/collection-mutation-service.ts:6262 <arrow> critical 175 ! 178 ! 6790 ! 1288
src/init/reload-config.ts:1319 applyReload critical 144 ! 228 ! 4623 ! 1433
shared/lib/entry-validation.ts:223 validateFieldValue critical 109 ! 157 ! 2675.3 ! 432
blocks-engine/src/measure-bytes.ts:646 surveyDocument critical 102 ! 250 ! 137.1 ! 658

5030 files, 77204 functions analyzed (thresholds: cyclomatic > 20, cognitive > 15, CRAP >= 30)

Codebase health

Metric Value
Maintainability 91.7 / 100
Avg complexity 1.8

Tip

Run fallow fix --dry-run to preview auto-fixes.
Add /** @public */ above exports to preserve them.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 691e389d39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions github-actions Bot added the type: docs Documentation only label Sep 11, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@nextlyhq/adapter-drizzle

npm i https://pkg.pr.new/@nextlyhq/adapter-drizzle@691e389

@nextlyhq/adapter-mysql

npm i https://pkg.pr.new/@nextlyhq/adapter-mysql@691e389

@nextlyhq/adapter-postgres

npm i https://pkg.pr.new/@nextlyhq/adapter-postgres@691e389

@nextlyhq/adapter-sqlite

npm i https://pkg.pr.new/@nextlyhq/adapter-sqlite@691e389

@nextlyhq/admin

npm i https://pkg.pr.new/@nextlyhq/admin@691e389

@nextlyhq/admin-css

npm i https://pkg.pr.new/@nextlyhq/admin-css@691e389

@nextlyhq/blocks-engine

npm i https://pkg.pr.new/@nextlyhq/blocks-engine@691e389

@nextlyhq/blocks-react

npm i https://pkg.pr.new/@nextlyhq/blocks-react@691e389

@nextlyhq/builder

npm i https://pkg.pr.new/@nextlyhq/builder@691e389

create-nextly-app

npm i https://pkg.pr.new/create-nextly-app@691e389

@nextlyhq/eslint-plugin

npm i https://pkg.pr.new/@nextlyhq/eslint-plugin@691e389

nextly

npm i https://pkg.pr.new/nextly@691e389

@nextlyhq/plugin-form-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-form-builder@691e389

@nextlyhq/plugin-page-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-page-builder@691e389

@nextlyhq/plugin-sdk

npm i https://pkg.pr.new/@nextlyhq/plugin-sdk@691e389

@nextlyhq/plugin-seo

npm i https://pkg.pr.new/@nextlyhq/plugin-seo@691e389

@nextlyhq/storage-s3

npm i https://pkg.pr.new/@nextlyhq/storage-s3@691e389

@nextlyhq/storage-uploadthing

npm i https://pkg.pr.new/@nextlyhq/storage-uploadthing@691e389

@nextlyhq/storage-vercel-blob

npm i https://pkg.pr.new/@nextlyhq/storage-vercel-blob@691e389

@nextlyhq/ui

npm i https://pkg.pr.new/@nextlyhq/ui@691e389

commit: 691e389

@mobeenabdullah

Copy link
Copy Markdown
Collaborator Author

Its two red legs are not this change and are already fixed on main. This branch was cut from 746a7141c, before #1807 merged, so its merge ref still fails transaction-update-writes-the-table › refuses a column the table does not have on postgres and mysql — the assertion #1807 repaired (348ceb93a). Integration (sqlite), Lint / Typecheck / Test / Build, Changed files and the blocking CI gate are green on 691e389d3.

Rebasing onto current main would swap those two for main's remaining red, outbox-preimage-lock (#1813 fixes it), so it cannot be green on those legs from here either way. Merge order that gets everything green: this one first — #1814 and #1813 inherit this doc-samples failure through their merge refs until it lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs Documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant