Repository navigation
fix(docs): a locale sample stops posing as a continuation, and the sample baseline catches up - #1810
Conversation
…mple baseline catches up main's Lint / Typecheck / Test / Build has failed at 'Doc samples compile' since the first run after #1769: the gate refuses more coverage than its baseline records until told. The rewrite it asks for refused too, and rightly: it would have recorded three new diagnostics on docs/plugins/services.mdx. Those came from a name. #1769's locale sample declared 'const page', and the checker reads a later fence that mentions an earlier fence's name as its continuation - so the Querying fence's 'pagination: { limit: 20, page: 1 }' made it compile with that sample's names, and its placeholders (ctx, slug, someId), never compiled before, became findings. Renamed to frenchPage, the Querying fence stops matching and the page records no diagnostics. The baseline then records only the coverage gained: services.mdx 4 -> 5 samples, and docs/widgets/index.mdx, new with #1782.
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
@nextlyhq/adapter-drizzle
@nextlyhq/adapter-mysql
@nextlyhq/adapter-postgres
@nextlyhq/adapter-sqlite
@nextlyhq/admin
@nextlyhq/admin-css
@nextlyhq/blocks-engine
@nextlyhq/blocks-react
@nextlyhq/builder
create-nextly-app
@nextlyhq/eslint-plugin
nextly
@nextlyhq/plugin-form-builder
@nextlyhq/plugin-page-builder
@nextlyhq/plugin-sdk
@nextlyhq/plugin-seo
@nextlyhq/storage-s3
@nextlyhq/storage-uploadthing
@nextlyhq/storage-vercel-blob
@nextlyhq/ui
commit: |
|
Its two red legs are not this change and are already fixed on Rebasing onto current |
What
Repairs
main's Lint / Typecheck / Test / Build (and so the blocking CI gate), red at the Doc samples compile step since the first run after my #1769.Ledger:
task:doc-sample-baseline-catches-up, fixingfinding:doc-samples-gate-red-since-1769; researchresearch:doc-sample-continuation-match.What was true on
mainmainpush from feat(nextly): a plugin names the locale it reads or writes in #1769 (4de79a213) until0121364ce, its first completed run:check:doc-samplesrefused because more samples were checked than the baseline records — then onlydocs/plugins/services.mdx, samples 4 → 5, compiled 0 → 1. By746a7141c, feat(nextly): a text widget declares its prose and the dashboard draws it #1782's newdocs/widgets/index.mdxjoined it.--write-baseline) refused too: it would have recorded three new diagnostics onservices.mdx—ctx,slug,someIdin the Querying fence.const page; the Querying fence containspagination: { limit: 20, page: 1 }; the key matched, the Querying fence compiled with the locale sample's names, and its placeholders — never compiled before — became findings.How
frenchPage. The Querying fence no longer matches,services.mdxcompiles 0 fences again and records no diagnostics. The fix is to the sample, as the gate's own message asks, not an--allow-new-findingsrecording of an artefact.services.mdx4 → 5,docs/widgets/index.mdxadded.Verification
746a7141c, the control):pnpm check:doc-samplesexit 1 with exactly CI's message. After: exit 0; again after the commit hook ran.pnpm test:scripts1344/1344 (the checker's own tests),check:docs-claims0,check:docs-compile0 (66 pages).constof the same spelling, so this can happen again.No changeset: docs and a CI baseline only.
Integration (postgres)/(mysql)stay red on this PR until #1807 lands — that ismain's other red, and it does not gate here.