Skip to content

fix(root): check a staged changeset at commit time - #1797

Merged
mobeenabdullah merged 1 commit into
mainfrom
fix/changesets-checked-at-commit
Sep 11, 2026
Merged

mobeenabdullah merged 1 commit into
mainfrom
fix/changesets-checked-at-commit

Conversation

@mobeenabdullah

Copy link
Copy Markdown
Collaborator

What

Two changesets whose frontmatter never closed reached main this afternoon (#1784's, repaired in #1791; then cd9554690's, repaired in #1795). Each broke pnpm changeset status for every checkout of main and would have failed the release's version step. CI's Changeset covers the lockstep group step refuses exactly these files — both merged while CI was still queued, so the gate ran after the merge.

The same checker, scripts/release/check-changesets.mjs, now runs from lint-staged on any staged .changeset/*.md, so the refusal reaches the author at commit time regardless of the CI queue. .husky/pre-commit runs lint-staged with --concurrent false: the changeset glob and the prettier glob both match those files, and run in parallel the checker can read a file prettier is halfway through writing.

Evidence

Through the real hook, on this branch:

  • staged a changeset with an unclosed frontmatter → git commit refused: ✖ .changeset/zz-probe-malformed.md: the frontmatter is missing or has a line this cannot read...
  • staged a copy of an existing well-formed changeset → git commit succeeded with Checked 1 changeset(s): all cover the group. (probe commit reset and the file removed before this push)

CI-only/tooling change — no changeset.

A changeset is read by the release, and one whose frontmatter never
closes fails `changeset version` for everybody once it is on main. CI
runs `check-changesets.mjs` on a pull request's changesets, and it
refuses such a file -- but a pull request merged while CI is still
queued lands before the check runs. Two such files landed on main in
one afternoon that way, each needing a repair pull request of its own.

The same checker now runs from lint-staged on any staged
`.changeset/*.md`, so the refusal reaches the author at commit time
whatever the queue is doing. lint-staged runs serially in the hook:
the changeset glob and the prettier glob both match those files, and
run at once the checker can read a file prettier is halfway through
writing.
@mobeenabdullah

Copy link
Copy Markdown
Collaborator Author

@codex review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6e599278-1f9c-402c-8148-b2417db0a3e5

📥 Commits

Reviewing files that changed from the base of the PR and between ebf8f78 and 6d43f2c.

📒 Files selected for processing (2)
  • .husky/pre-commit
  • lint-staged.config.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T13:48:31.929310Z 6d43f2c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 6d43f2cbaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@nextlyhq/adapter-drizzle

npm i https://pkg.pr.new/@nextlyhq/adapter-drizzle@6d43f2c

@nextlyhq/adapter-mysql

npm i https://pkg.pr.new/@nextlyhq/adapter-mysql@6d43f2c

@nextlyhq/adapter-postgres

npm i https://pkg.pr.new/@nextlyhq/adapter-postgres@6d43f2c

@nextlyhq/adapter-sqlite

npm i https://pkg.pr.new/@nextlyhq/adapter-sqlite@6d43f2c

@nextlyhq/admin

npm i https://pkg.pr.new/@nextlyhq/admin@6d43f2c

@nextlyhq/admin-css

npm i https://pkg.pr.new/@nextlyhq/admin-css@6d43f2c

@nextlyhq/blocks-engine

npm i https://pkg.pr.new/@nextlyhq/blocks-engine@6d43f2c

@nextlyhq/blocks-react

npm i https://pkg.pr.new/@nextlyhq/blocks-react@6d43f2c

@nextlyhq/builder

npm i https://pkg.pr.new/@nextlyhq/builder@6d43f2c

create-nextly-app

npm i https://pkg.pr.new/create-nextly-app@6d43f2c

@nextlyhq/eslint-plugin

npm i https://pkg.pr.new/@nextlyhq/eslint-plugin@6d43f2c

nextly

npm i https://pkg.pr.new/nextly@6d43f2c

@nextlyhq/plugin-form-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-form-builder@6d43f2c

@nextlyhq/plugin-page-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-page-builder@6d43f2c

@nextlyhq/plugin-sdk

npm i https://pkg.pr.new/@nextlyhq/plugin-sdk@6d43f2c

@nextlyhq/plugin-seo

npm i https://pkg.pr.new/@nextlyhq/plugin-seo@6d43f2c

@nextlyhq/storage-s3

npm i https://pkg.pr.new/@nextlyhq/storage-s3@6d43f2c

@nextlyhq/storage-uploadthing

npm i https://pkg.pr.new/@nextlyhq/storage-uploadthing@6d43f2c

@nextlyhq/storage-vercel-blob

npm i https://pkg.pr.new/@nextlyhq/storage-vercel-blob@6d43f2c

@nextlyhq/ui

npm i https://pkg.pr.new/@nextlyhq/ui@6d43f2c

commit: 6d43f2c

@github-actions

Copy link
Copy Markdown
Contributor

Whole-Repository Code Hygiene Summary

Full dead-code, duplication, and complexity report for the PR branch as it stands now. Playground is excluded. Quality gate enforcement on introduced issues is performed by the Changed files job.

🌿 Fallow

Warning

Review needed

⚠️ 73 code issues · ⚠️ 690 clone groups · ⚠️ 1045 health findings

See inline review comments for per-finding details.

Code issues (73)
Category Count
Unused files 2
Unused exports 5
Unused dependencies 19
Unused devDependencies 6
Unresolved imports 2
Unlisted dependencies 1
Circular dependencies 38
Duplication (690 groups · 28909 lines · 4.1%)
Locations Lines Tokens
schemas/_dialect-bundles/mysql.relations.ts:40-134
schemas/_dialect-bundles/postgres.relations.ts:40-134
schemas/_dialect-bundles/sqlite.relations.ts:40-134
95 593
cli/commands/db-sync-demote.ts:70-75
cli/commands/db-sync-promote.ts:38-43
cli/commands/dev-build.ts:100-105
cli/commands/dev-build.ts:179-184
cli/commands/dev-build.ts:299-304
cli/commands/dev-build.ts:411-416
cli/commands/dev-build.ts:552-557
cli/commands/dev-server.ts:575-580
cli/commands/dev-server.ts:840-845
cli/commands/dev-server.ts:1143-1148
cli/commands/migrate-field-groups.ts:110-115
6 70
entries/EntryList/EntryTableSkeleton.tsx:74-98
collection/components/CollectionTableSkeleton.tsx:94-118
field-group/components/FieldGroupTableSkeleton.tsx:90-114
plugins/components/PluginsTableSkeleton.tsx:86-110
singles/components/SinglesTableSkeleton.tsx:77-101
src/components/table-skeleton.tsx:100-124
25 89
collections/config/validate-config.ts:380-433
field-groups/config/validate-field-group.ts:185-238
singles/config/validate-single.ts:190-243
54 152
dispatcher/handlers/collection-dispatcher.ts:925-967
field-groups/services/field-group-table-provisioning.ts:186-236
singles/services/reconcile-single-companion.ts:110-160
51 149

… and 685 more groups.

Across 422 files.

Complexity (1045 functions above threshold)
File Function Severity Cyclomatic Cognitive CRAP Lines
singles/services/single-mutation-service.ts:981 <arrow> critical 251 ! 324 ! 13859.2 ! 1625
collections/services/collection-mutation-service.ts:6264 <arrow> critical 174 ! 177 ! 6713.6 ! 1301
src/init/reload-config.ts:1319 applyReload critical 144 ! 228 ! 4623 ! 1433
shared/lib/entry-validation.ts:223 validateFieldValue critical 109 ! 157 ! 2675.3 ! 432
blocks-engine/src/measure-bytes.ts:646 surveyDocument critical 102 ! 250 ! 137.1 ! 658

5009 files, 76751 functions analyzed (thresholds: cyclomatic > 20, cognitive > 15, CRAP >= 30)

Codebase health

Metric Value
Maintainability 91.7 / 100
Avg complexity 1.8

Tip

Run fallow fix --dry-run to preview auto-fixes.
Add /** @public */ above exports to preserve them.

@mobeenabdullah
mobeenabdullah merged commit e3b3037 into main Sep 11, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant