test(admin): a drop target is an Over, not an Active, so check-types passes on main - #1790
Conversation
…passes on main The two onDragEnd cases handed an Active where dnd-kit's Over is required, which lacks the disabled flag and carries a resolved rect; @nextlyhq/admin failed check-types on main since #1776.
|
@codex review |
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What
mainfails@nextlyhq/admincheck-typessince #1776:Two
onDragEndcases built the drop target with the test'sActivehelper. dnd-kit'sOveris a different shape: a resolved rect and adisabledflag. Anoverhelper now builds one, the same shapesortable-announcements.test.tsxalready uses.Why it reached main
Same as #1780: merged while CI's queue could not report (#1778), and the pre-push hook of the day printed the type error as a note. #1781 has since made the hook refuse a type error in the packages a push affects.
Changeset
None. Test-only.