Repository navigation
chore(plugin-page-builder): drop the dnd-kit dependencies nothing imports - #1032
Merged
Merged
Conversation
…orts The canvas drag shipped on its own region-and-line model rather than on dnd-kit, and the declarations were left behind. @dnd-kit/dom and @dnd-kit/react sat in dependencies, so every install of the plugin downloaded them for nothing. Absence verified with a positive control: 17 files in this package import @nextlyhq/blocks-engine, and zero files anywhere in the workspace import any of the three packages removed.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 28 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
type: docs
Contributor
Fallow audit reportFound 37 findings. Details
Generated by fallow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextlyhq/plugin-page-builderdeclared@dnd-kit/domand@dnd-kit/reactindependencies, plus@dnd-kit/abstractin devDependencies. Nothing imports any of them.They are left over from the dnd-kit spike. That spike was discharged and the canvas drag shipped in #1007 on its own region-and-line model instead — but the declarations stayed, so every install of this plugin has been downloading two runtime packages it never loads.
Surfaced by the Fallow audit on #1025, which reports them as
unused-dependency(major). Nothing else in that report belongs to this lane; the rest is pre-existing and untouched here.Absence verified with a positive control
An absence claim is only as good as the proof the search could have found something:
@nextlyhq/blocks-engineinpackages/plugin-page-builder/src(positive control)@dnd-kit/domacross all workspace source@dnd-kit/reactacross all workspace source@dnd-kit/abstractacross all workspace sourceSearched with
git grepover*.ts,tsx,mts,cts,js,mjs, because the shell'sgrephere isugrep, which classifies some files as binary and skips them silently. The only remaining mentions of "dnd-kit" anywhere in the package are CHANGELOG prose and thepackage.jsonlines this PR removes.@dnd-kit/coreinpackages/adminis a different package and is genuinely used bySortableFieldsTable; it is untouched.Verified
Runtime, in a browser (playground on
:3123, auth control asserted first —h1reads "Welcome, Dev"), because a dependency removal is exactly the change whose failure is a runtime resolution error rather than a build one. Afterpnpm installand a full rebuild with the packages gone:["autosave-recovery","collection","pages",…]one, which is unrelated and present on main.Gates:
plugin-page-builder61 tests, types and lint clean; workspace build green.sherifreports 0 errors — its 2 warnings are pre-existing and concern the rootpackage.jsonand a phantompackages/node_modules, neither touched here.