fix: Allow accessing some admin endpoints to admins that can not use Talk - #18107
Merged
danxuliu merged 2 commits intoMay 27, 2026
Merged
Conversation
Since Talk 21 the connection check for the signaling server in Talk administration settings fetches the signaling settings, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
regression
feature: settings ⚙️
Member
Author
|
/backport to stable34 please |
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
Talk administration settings fetches the list of all bots, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
changed the title
danxuliu
marked this pull request as ready for review
May 27, 2026 06:36
Antreesy
approved these changes
May 27, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Tested, change sounds valid!
danxuliu
deleted the
allow-accessing-signaling-settings-to-admins-that-can-not-use-talk
branch
May 27, 2026 16:29
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8330 and #13973
Since Talk 21 the connection check for the signaling server in Talk administration settings fetches the signaling settings, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk.
Similarly, Talk administration settings fetches the list of all bots, so that endpoint should be allowed too.
How to test (scenario 1)
Result with this pull request
The connection check still succeeds and returns the signaling server information
Result without this pull request
The connection check now fails with
Error: unknown error occurred; in the Network tab of the browser it can be seen that the request toocs/v2.php/apps/spreed/api/v3/signaling/settings?token=fails with 403 Forbidden and the messageCan not use Talkin the response.How to test (scenario 2)
Result with this pull request
The request to
ocs/v2.php/apps/spreed/api/v1/bot/adminsucceedsResult without this pull request
The request to
ocs/v2.php/apps/spreed/api/v1/bot/adminfails with 403 Forbidden and the messageCan not use Talkin the response.