fix(webrtc): Calculate maxBitrates based on HPBs maxstreambits - #17670
Open
nickvergessen wants to merge 4 commits into
Open
fix(webrtc): Calculate maxBitrates based on HPBs maxstreambits#17670nickvergessen wants to merge 4 commits into
nickvergessen wants to merge 4 commits into
Conversation
fancycode
reviewed
Apr 23, 2026
| if (data.room?.bandwidth?.maxstreambitrate) { | ||
| const totalBps = data.room.bandwidth.maxstreambitrate | ||
| if (typeof totalBps === 'number' && totalBps > 0) { | ||
| this.maxStreamBits = data.room.bandwidth.maxstreambitrate |
Member
There was a problem hiding this comment.
Suggested change
| this.maxStreamBits = data.room.bandwidth.maxstreambitrate | |
| this.maxStreamBits = totalBps |
Also you should reset this.maxStreamBits to the default value if no bandwidth limit is returned in the join response.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…eck sent kbps by each layer Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
bugfix/16266/optimize-maxbits-to-be-inline-with-hpb
branch
from
July 20, 2026 13:32
84cc49a to
c2d2fe7
Compare
Contributor
Noticed issues:
Results for Chrome (can be used, if we want to adjust mid/low):4Mbps
2Mbps
1.5Mbps
1Mbps
0.5Mbps
TL;DR Change, affecting Firefox:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Unfortunately despite first successes the more I tested, the less it made a difference. I assume it's due to load on my machine
🏁 Checklist