fix: make top nav bar right elements within a nav - #63239
Open
kristian-zendato wants to merge 1 commit into
Open
fix: make top nav bar right elements within a nav#63239kristian-zendato wants to merge 1 commit into
kristian-zendato wants to merge 1 commit into
Conversation
Signed-off-by: kristian.zendato <kristian.zendato@nextcloud.com>
kristian-zendato
requested review from
icewind1991,
leftybournes,
provokateurin,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
August 14, 2026 06:42
susnux
reviewed
Aug 14, 2026
| <div id="contactsmenu"></div> | ||
| <div id="user-menu"></div> | ||
| </div> | ||
| <nav class="header-end" aria-label="<?php p($l->t('User menu')); ?>"> |
Contributor
There was a problem hiding this comment.
Thats not the user menu, the user menu is the one on the very end.
This navigation should have a different label
Also the content within must have proper roles.
ulneedsrole = menubarlineedsrole = none- button within need
role = menuitem-> this needs to be fixed in NcHeaderButton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navelement.Checklist
3. to review, feature component)stable32)AI (if applicable)