Skip to content

refactor: allow non-lowercase string in ITable methods #63219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 1 commit into from
Aug 13, 2026
+13 −13
Merged

refactor: allow non-lowercase string in ITable methods #63219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/DB/Schema/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function getWrappedTable(): DBALTable {

#[\Override]
public function getName(): string {
/** @var non-empty-lowercase-string $name */
/** @var non-empty-string $name */
$name = $this->table->getName();
return $name;
}
Expand Down
24 changes: 12 additions & 12 deletions lib/public/DB/Schema/ITable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ interface ITable {
* Returns the name of this table.
*
* @since 35.0.0
* @return non-empty-lowercase-string
* @return non-empty-string
*/
public function getName(): string;

Expand All @@ -39,10 +39,10 @@ public function getName(): string;
public function setPrimaryKey(array $columnNames, string|false $indexName = false): self;

/**
* @param list<non-empty-lowercase-string> $columnNames
* @param list<non-empty-string> $columnNames
* @param ?non-empty-string $indexName
* @param list<non-empty-lowercase-string> $flags
* @param array<non-empty-lowercase-string, mixed> $options
* @param list<non-empty-string> $flags
* @param array<non-empty-string, mixed> $options
*
* @throws SchemaException
* @since 35.0.0
Expand Down Expand Up @@ -146,7 +146,7 @@ public function addUniqueIndex(array $columnNames, ?string $indexName = null, ar
public function renameIndex(string $oldName, ?string $newName = null): self;

/**
* @param non-empty-lowercase-string $name
* @param non-empty-string $name
* @param Types::*|ColumnType $typeName
* @param array{
* notnull?: bool,
Expand All @@ -167,7 +167,7 @@ public function renameIndex(string $oldName, ?string $newName = null): self;
public function addColumn(string $name, string|ColumnType $typeName, array $options = []): IColumn;

/**
* @param non-empty-lowercase-string $name
* @param non-empty-string $name
* @param array{
* notnull?: bool,
* length?: ?int,
Expand All @@ -189,23 +189,23 @@ public function modifyColumn(string $name, array $options): self;
/**
* Drops a Column from the Table.
*
* @param non-empty-lowercase-string $name
* @param non-empty-string $name
* @since 35.0.0
*/
public function dropColumn(string $name): self;

/**
* Returns whether this table has a Column with the given name.
*
* @param non-empty-lowercase-string $name The column name.
* @param non-empty-string $name The column name.
* @since 35.0.0
*/
public function hasColumn(string $name): bool;

/**
* Returns the Column with the given name.
*
* @param non-empty-lowercase-string $name The column name.
* @param non-empty-string $name The column name.
*
* @throws SchemaException If the column does not exist.
* @since 35.0.0
Expand Down Expand Up @@ -242,9 +242,9 @@ public function getIndex(string $name): IIndex;
*
* Name is inferred from the local columns.
*
* @param ITable|non-empty-lowercase-string $foreignTable Table schema instance or table name
* @param list<non-empty-lowercase-string> $localColumnNames
* @param list<non-empty-lowercase-string> $foreignColumnNames
* @param ITable|non-empty-string $foreignTable Table schema instance or table name
* @param list<non-empty-string> $localColumnNames
* @param list<non-empty-string> $foreignColumnNames
* @param array<string, mixed> $options
*
* @throws SchemaException
Expand Down
Loading