Skip to content

chore: Fix PHP 7.3 support #63216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Aug 13, 2026
+2 −2
Merged

chore: Fix PHP 7.3 support #63216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf9bf5
chore: Fix PHP 7.3 support
come-nc Aug 13, 2026
fbb4a8d
ci: run jsunit on self-hosted
blizzz Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
run: npm run test

jsunit:
runs-on: ubuntu-latest
runs-on: [ubuntu-latest, self-hosted]
needs: versions

steps:
Expand Down
2 changes: 1 addition & 1 deletion lib/private/User/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ public function tryBasicAuthLogin(IRequest $request,
throw new LoginException();
} catch (PasswordLoginForbiddenException $ex) {
// If credentials were provided, they need to be valid, otherwise we do boom
throw new LoginException(previous: $ex);
throw new LoginException('', 0, $ex);
}
}
return false;
Expand Down
Loading