fix: Extend AI communication - #63211
Conversation
Forbid AI written comments and commit messages Signed-off-by: Louis <louis@chmn.me>
| * **Accountability:** You must be able to explain, defend, and modify every line you submit. If a reviewer asks why something works a certain way, "the AI wrote it" is not an answer. | ||
|
|
||
| * **Communication:** PR descriptions, review comments, and issue reports must be written in your own words. This applies throughout the review process - passing reviewer feedback to an AI and posting whatever comes out is not acceptable. | ||
| * **Communication:** PR descriptions, review comments, issue reports, code comments and commit messages must be written in your own words. This applies throughout the review process - passing reviewer feedback to an AI and posting whatever comes out is not acceptable. |
There was a problem hiding this comment.
why no code comments?
We recently adjusted that in the AI_POLICY to make them useful. And from experience if you properly guide the model on what to add as comments they are quite good.
There was a problem hiding this comment.
Same thought on the comment - but also on the commit messages. Yes they get veeery lengthy when you ask AI to do them (while you can of course tell it not to do that). When I i.e. worked on Talk Android aspects I asked explicitly if it should be a short (like 1-liner) commit message or if I should push long(er) AI generated commit messages - the feedback has been: the long8er) AI ones (to have this "for later"/future).
So my interpretation from that would be, to still allow them, while the 1-line semantic commit message should be what is relevant for the reviewer(s) while the lenghty version serves as a documentation if one ever would need to dig into the commit history to gain more context by having more git based documentation
Forbid AI written comments and commit messages. When generated by AI those are usually really bad and confusing.