Skip to content

fix(user_ldap): restore OCS API functionality for configID = '' #63165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmart-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix(user_ldap): restore OCS API functionality for configID = '' #63165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/user_ldap/lib/Controller/ConfigAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function create() {
* 200: Config deleted successfully
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
#[ApiRoute(verb: 'DELETE', url: '/api/v1/config/{configID}')]
#[ApiRoute(verb: 'DELETE', url: '/api/v1/config/{configID}', requirements: ['configID' => '.*'], defaults: ['configID' => ''])]
public function delete($configID) {
try {
$this->ensureConfigIDExists($configID);
Expand Down Expand Up @@ -102,7 +102,7 @@ public function delete($configID) {
* 200: Config returned
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
#[ApiRoute(verb: 'PUT', url: '/api/v1/config/{configID}')]
#[ApiRoute(verb: 'PUT', url: '/api/v1/config/{configID}', requirements: ['configID' => '.*'], defaults: ['configID' => ''])]
public function modify($configID, $configData) {
try {
$this->ensureConfigIDExists($configID);
Expand Down Expand Up @@ -207,7 +207,7 @@ public function modify($configID, $configData) {
* 200: Config returned
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
#[ApiRoute(verb: 'GET', url: '/api/v1/config/{configID}')]
#[ApiRoute(verb: 'GET', url: '/api/v1/config/{configID}', requirements: ['configID' => '.*'], defaults: ['configID' => ''])]
public function show($configID, $showPassword = false) {
try {
$this->ensureConfigIDExists($configID);
Expand Down Expand Up @@ -244,7 +244,7 @@ public function show($configID, $showPassword = false) {
* 200: Test was run and results are returned
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
#[ApiRoute(verb: 'POST', url: '/api/v1/config/{configID}/test')]
#[ApiRoute(verb: 'POST', url: '/api/v1/config/{configID}/test', requirements: ['configID' => '.*'], defaults: ['configID' => ''])]
public function testConfiguration(string $configID) {
try {
$this->ensureConfigIDExists($configID);
Expand Down Expand Up @@ -312,7 +312,7 @@ public function testConfiguration(string $configID) {
* 200: Config was copied, new configID was returned
*/
#[AuthorizedAdminSetting(settings: Admin::class)]
#[ApiRoute(verb: 'POST', url: '/api/v1/config/{configID}/copy')]
#[ApiRoute(verb: 'POST', url: '/api/v1/config/{configID}/copy', requirements: ['configID' => '.*'], defaults: ['configID' => ''])]
public function copyConfiguration(string $configID) {
try {
$this->ensureConfigIDExists($configID);
Expand Down
Loading