Skip to content

fix(files_versions): pass missing fileInfo properties to Viewer.compare - #63149

Merged
mejo- merged 2 commits into
masterfrom
fix/version_compare_fileinfo
Aug 11, 2026
Merged

fix(files_versions): pass missing fileInfo properties to Viewer.compare#63149
mejo- merged 2 commits into
masterfrom
fix/version_compare_fileinfo

Conversation

@mejo-

@mejo- mejo- commented Aug 11, 2026

Copy link
Copy Markdown
Member

Fixes side-by-side comparison of Markdown documents in Files/Viewer.

Fixes the Viewer throwing "TypeError: can't access property "split", mime is undefined".

Fixes: nextcloud/text#8956
Fixes: nextcloud/viewer#3128

Checklist

@mejo-
mejo- requested a review from a team as a code owner August 11, 2026 08:28
@mejo-
mejo- requested review from kristian-zendato, skjnldsv and susnux and removed request for a team August 11, 2026 08:28
@mejo- mejo- self-assigned this Aug 11, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Aug 11, 2026
@mejo- mejo- added this to the Nextcloud 35 milestone Aug 11, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Aug 11, 2026
Fixes the Viewer throwing "TypeError: can't access property "split",
mime is undefined".

Fixes: nextcloud/text#8956

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo- force-pushed the fix/version_compare_fileinfo branch from c638f7a to 8e87882 Compare August 11, 2026 08:54
@mejo-

mejo- commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-
mejo- merged commit a5e3dc6 into master Aug 11, 2026
132 checks passed
@mejo-
mejo- deleted the fix/version_compare_fileinfo branch August 11, 2026 09:42
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Aug 11, 2026
@mejo-

mejo- commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@mejo-

mejo- commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@nextcloud nextcloud deleted a comment from backportbot Bot Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: compare with old version is broken [Bug]: The file compare feature does not work

4 participants