refactor: use Share for most SharingManager parameters instead of just the id - #63140
Merged
Conversation
icewind1991
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
August 10, 2026 23:34
icewind1991
force-pushed
the
unified-sharing-share-instead-id
branch
3 times, most recently
from
August 11, 2026 01:04
bfd5bfd to
c21d453
Compare
CarlSchwan
approved these changes
Aug 11, 2026
This comment was marked as outdated.
This comment was marked as outdated.
icewind1991
force-pushed
the
unified-sharing-share-instead-id
branch
2 times, most recently
from
August 11, 2026 14:24
c85f755 to
567422f
Compare
…t the id Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # tests/lib/Sharing/AbstractSharingManagerTests.php # Conflicts: # apps/sharing/tests/Controller/ApiV1ControllerTest.php # tests/lib/Sharing/AbstractSharingManagerTests.php
icewind1991
force-pushed
the
unified-sharing-share-instead-id
branch
from
August 11, 2026 14:40
567422f to
55e1270
Compare
susnux
approved these changes
Aug 11, 2026
Draft
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change most methods in
ISharingManagerfrom taking anstring $idto aShare $share, and return the updated share for any relevant methods.processShareUpdates, having the caller fetch the share (if they don't have it already) is free.As part of making this work properly, default values for permissions/properties are now applied once a source/recipient is added instead of only when listing shares.
Checklist
3. to review, feature component)stable32)AI (if applicable)